fix: set marker slot in default constructor to ensure visibility

paodb · javier-godoy · commit d87fab7d9b3f · 2025-06-06T16:54:54.000-03:00
Close #153
diff --git a/src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapMarker.java b/src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapMarker.java
@@ -53,6 +53,7 @@ public class GoogleMapMarker extends Component {
   public GoogleMapMarker() {
     id = idCounter;
     idCounter++;
+    this.getElement().setAttribute("slot", "markers");
   }
 
   /**
@@ -67,7 +68,6 @@ public GoogleMapMarker(String caption, LatLon position, boolean draggable) {
     this.setCaption(caption);
     this.setPosition(position);
     this.setDraggable(draggable);
-    this.getElement().setAttribute("slot", "markers");
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,7 @@ public class GoogleMapMarker extends Component {`
`53`	`53`	`public GoogleMapMarker() {`
`54`	`54`	`id = idCounter;`
`55`	`55`	`idCounter++;`
	`56`	`+ this.getElement().setAttribute("slot", "markers");`
`56`	`57`	`}`
`57`	`58`
`58`	`59`	`/**`
`@@ -67,7 +68,6 @@ public GoogleMapMarker(String caption, LatLon position, boolean draggable) {`
`67`	`68`	`this.setCaption(caption);`
`68`	`69`	`this.setPosition(position);`
`69`	`70`	`this.setDraggable(draggable);`
`70`		`- this.getElement().setAttribute("slot", "markers");`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`/**`