-
-
Notifications
You must be signed in to change notification settings - Fork 28
Open
Description
Is the following line in lapack.jl
even reachable?
LinearAlgebra.jl/src/lapack.jl
Line 4141 in 2a1696a
error("failed to converge eigenvectors:\n$(findall(!iszero, ifail))") |
The call to chklapackerror(info[])
on line 4138
LinearAlgebra.jl/src/lapack.jl
Line 4138 in 2a1696a
chklapackerror(info[]) |
should throw an error if any of the eigenvectors failed to converge and therefore its unlikely the if block would ever be reached.
can someone suggest a test for this? I tried a bunch of matrices from the MatrixDepot.jl
packages but none of them threw any errors when running eigen
.
The relevant code for context (comments with <--
mine)
# .... #
# lapack.jl lines 4138 - 4142
chklapackerror(info[])
if any(ifail .!= 0) # <-- should be unreachable because of the line above
# TODO: better error message / type
error("failed to converge eigenvectors:\n$(findall(!iszero, ifail))") # <-- this line here
end
# ... #
Metadata
Metadata
Assignees
Labels
No labels