Paths should use platform-specific standards.

[hexmode]

Instead of defaulting to $HOME or ~, they should use $XDG_DATA_HOME or (if that is not set or empty) $HOME/.local/share. See XDG Base Directory Specificatin §3.

Following this standard, the config file should use $XDG_CONFIG_HOME or $HOME/.config.

The xdg-base-dirs python module supports this standard and is linux focused. appdirs does something similar for Linux but also provides sensible defaults for OS X and Windows.

[bilersan]

also, other paths seems to be problematic...

im on wsl2 and did pip install npcsh[all] and the installation process did not install "all" and i had to install many missing libraries including faster_whisper

here is an example of wrong path usage - instead of looking into ~/.npcsh , it looks for home folder

/home/ersan:sibiji> exit
Exiting sibiji mode.
/home/ersan:npcsh!> /sample hi
Traceback (most recent call last):
File "/home/ersan/micromamba/envs/npcsh/lib/python3.10/site-packages/npcsh/npc_compiler.py", line 1830, in load_npc_from_file
with open(npc_file, "r") as f:
FileNotFoundError: [Errno 2] No such file or directory: '/home/ersan/sibiji.npc'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/home/ersan/micromamba/envs/npcsh/bin/npcsh", line 8, in
sys.exit(main())
File "/home/ersan/micromamba/envs/npcsh/lib/python3.10/site-packages/npcsh/shell.py", line 358, in main
result = execute_command(
File "/home/ersan/micromamba/envs/npcsh/lib/python3.10/site-packages/npcsh/shell_helpers.py", line 2453, in execute_command
npc = load_npc_from_file(npc_path, db_conn)
File "/home/ersan/micromamba/envs/npcsh/lib/python3.10/site-packages/npcsh/npc_compiler.py", line 1881, in load_npc_from_file
raise ValueError(f"NPC file not found: {npc_file}")
ValueError: NPC file not found: /home/ersan/sibiji.npc
(npcsh) ersan@ERSAN-DESKTOP:$ cd /.npcsh
(npcsh) ersan@ERSAN-DESKTOP:/.npcsh$ dir
npc_team
(npcsh) ersan@ERSAN-DESKTOP:/.npcsh$ cd npc_team/
(npcsh) ersan@ERSAN-DESKTOP:/.npcsh/npc_team$ dir
corca.npc foreman.npc sibiji.npc templates tools
(npcsh) ersan@ERSAN-DESKTOP:/.npcsh/npc_team$

[cagostino]

hmmm yeah the faster_whisper was a newer one but i thought i included in most recent release but ill check.
otherwise the problem here looks like its not prepending well.
@bilersan i think the thing youre pointing out above is actually more of a NPC resolution issue than a path one necessarily .
im away from my own windows machine for the next few days so wont be able to check more on this until then.

@bilersan did it successfully create a .npcshrc file or a .npcsh folder within the "home" directory or anywhere at all ? or just missing? cause it should have given some other kind of error if it wasnt able to do that.
thanks and lmk 😁

[jcheek]

I can confirm that faster_whisper is not installed on a clean install of npcsh. nor is torchaudio nor pygame.

[cagostino]

thanks for confirming @jcheek. I'll have them fixed and included in next release in #148, hoping to close it out tonight