A design question about FD usages #1154
Closed
zefengsysu
started this conversation in
General
Replies: 2 comments 6 replies
-
There's a report that on iOS closing FD will make mmap fail to work inter-process. Yet I don't have the time to verify that. |
Beta Was this translation helpful? Give feedback.
6 replies
-
The FD usage has largely reduced in v2.2.0. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
MMKV use two FD for each MMKV instance now, one for the MMKV file, and another for the meta file, and MMKV's file lock implementation reuse the meta file's FD.
Since close FD after mmap return is ok, can we close the MMKV file's FD after new MemoryFile instance ready, for reduce the overhead of FD?
Beta Was this translation helpful? Give feedback.
All reactions