Skip to content

Commit 8c0cb0a

Browse files
authored
Revert "Debug subscription filters fix (#1967)" (#1975)
This reverts commit 93f949d.
1 parent fdb4854 commit 8c0cb0a

File tree

3 files changed

+22
-23
lines changed

3 files changed

+22
-23
lines changed

hermes-console/src/views/subscription/subscription-form/subscription-basic-filters/path-filter-row/PathFilterRow.vue

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</script>
2222

2323
<template>
24-
<v-row class="my-0" v-if="props.type === 'created'">
24+
<v-row class="mt-0">
2525
<v-col cols="5">
2626
<v-combobox
2727
:items="paths"
@@ -55,25 +55,21 @@
5555

5656
<v-col cols="1">
5757
<v-btn
58+
v-if="props.type === 'new'"
5859
:ripple="false"
59-
color="error"
60-
icon="mdi-delete"
60+
color="success"
61+
icon="mdi-plus-circle"
6162
variant="text"
62-
@click="$emit('remove')"
63+
@click="$emit('add')"
6364
/>
64-
</v-col>
65-
</v-row>
66-
<v-row class="mt-0" v-else justify="end">
67-
<v-col class="pt-0" cols="2">
6865
<v-btn
69-
v-if="props.type === 'new'"
66+
v-else
7067
:ripple="false"
71-
color="success"
68+
color="error"
69+
icon="mdi-delete"
7270
variant="text"
73-
@click="$emit('add')"
74-
>
75-
Add Filter
76-
</v-btn>
71+
@click="$emit('remove')"
72+
/>
7773
</v-col>
7874
</v-row>
7975
</template>

hermes-console/src/views/subscription/subscription-form/subscription-header-filters/SubscriptionHeaderFilters.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
v-model:matcher="newFilterMatcher"
4747
@add="addFilter()"
4848
type="new"
49-
class="mb-3"
5049
/>
5150
</template>
5251

hermes-console/src/views/subscription/subscription-form/subscription-header-filters/header-filter-row/HeaderFilterRow.vue

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222

2323
<template>
2424
<v-form v-model="isFormValid" @submit.prevent="submit">
25-
<v-row v-if="props.type === 'created'">
26-
<v-col cols="5">
25+
<v-row>
26+
<v-col>
2727
<text-field
2828
:model-value="props.name"
2929
@input="$emit('update:name', $event.target.value)"
@@ -32,7 +32,7 @@
3232
/>
3333
</v-col>
3434

35-
<v-col cols="5">
35+
<v-col>
3636
<text-field
3737
:model-value="props.matcher"
3838
@input="$emit('update:matcher', $event.target.value)"
@@ -43,6 +43,15 @@
4343

4444
<v-col>
4545
<v-btn
46+
v-if="props.type === 'new'"
47+
type="submit"
48+
:ripple="false"
49+
variant="text"
50+
icon="mdi-plus-circle"
51+
color="success"
52+
/>
53+
<v-btn
54+
v-else
4655
type="submit"
4756
:ripple="false"
4857
variant="text"
@@ -51,11 +60,6 @@
5160
/>
5261
</v-col>
5362
</v-row>
54-
<v-row v-else justify="end">
55-
<v-btn type="submit" :ripple="false" variant="text" color="success">
56-
Add Filter
57-
</v-btn>
58-
</v-row>
5963
</v-form>
6064
</template>
6165

0 commit comments

Comments
 (0)