Skip to content

Commit 671a9ed

Browse files
Modify global CSS file, rename files in img directory, cleanup content in html head element, remove redundant header element wrapper around nav element in all html files
css/global.css: - Have style for header elements be applied to nav elements. img/profile-pic.jpg: - Rename from "profile_pic.jpg" to be more consistent with naming scheme. about.html, contact.html, index.html, projects.html, resumes.html: - Reorganize head element content. Meta tags on top, followed by document name, followed by third-party library imports, followed by developer imports. - Remove redundant header element wrap around nav element.
1 parent 4412137 commit 671a9ed

File tree

7 files changed

+138
-186
lines changed

7 files changed

+138
-186
lines changed

about.html

Lines changed: 27 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -7,61 +7,52 @@
77
<meta charset="utf-8">
88
<meta name="viewport" content="width=device-width, initial-scale=1">
99

10-
<!-- Import core Bootstrap CSS. -->
10+
<!-- Document name. -->
11+
<title>About | David Read's Portfolio</title>
12+
13+
<!-- Import core Bootstrap library CSS and JS. -->
1114
<link href="https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-1BmE4kWBq78iYhFldvKuhfTAU6auU8tT94WrHftjDbrCEXSU1oBoqyl2QvZ6jIW3" crossorigin="anonymous">
15+
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/js/bootstrap.bundle.min.js" integrity="sha384-ka7Sk0Gln4gmtz2MlQnikT1wXgYsOg+OMhuP+IlRH9sENBO0LRn5q+8nbTov4+1p" crossorigin="anonymous"></script>
16+
17+
<!-- Import Font Awesome library JS. -->
18+
<script src="https://kit.fontawesome.com/b06b68bfd6.js" crossorigin="anonymous"></script>
19+
20+
<!-- Import jQuery library JS.-->
21+
<script src="js/jquery.js"></script>
1222

1323
<!-- Import developer CSS. -->
1424
<link href="css/global.css" rel="stylesheet">
1525
<link href="css/about.css" rel="stylesheet">
1626

17-
<!-- Import jQuery JS.-->
18-
<script src="https://code.jquery.com/jquery-3.3.1.slim.min.js" integrity="sha384-q8i/X+965DzO0rT7abK41JStQIAqVgRVzpbzo5smXKp4YfRvH+8abtTE1Pi6jizo" crossorigin="anonymous"></script>
19-
20-
<!-- Import core Bootstrap JS. -->
21-
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/js/bootstrap.bundle.min.js" integrity="sha384-ka7Sk0Gln4gmtz2MlQnikT1wXgYsOg+OMhuP+IlRH9sENBO0LRn5q+8nbTov4+1p" crossorigin="anonymous"></script>
22-
23-
<!-- Import jQuery JS. -->
24-
<script src="js/jquery.js"></script>
25-
2627
<!-- Import developer JS. -->
2728
<script src="js/navbar.js"></script>
2829

29-
<!-- Import Font Awesome kit. -->
30-
<script src="https://kit.fontawesome.com/b06b68bfd6.js" crossorigin="anonymous"></script>
31-
32-
<!-- Document title. -->
33-
<title>About | David Read's Portfolio</title>
34-
3530
</head>
3631

3732
<body class="h-100 d-flex flex-column text-white">
3833

39-
<!-- Header. -->
40-
<header class="mb-auto p-3">
41-
42-
<!-- Navbar component. -->
43-
<nav class="navbar navbar-expand-sm navbar-dark">
34+
<!-- Nav header. -->
35+
<nav class="mb-auto p-3 navbar navbar-expand-sm navbar-dark">
4436

45-
<!-- Navbar brand component. -->
46-
<span class="navbar-brand floa">David Read</span>
37+
<!-- Navbar brand component. -->
38+
<span class="navbar-brand floa">David Read</span>
4739

48-
<!-- Navbar nav items component.-->
49-
<div class="navbar-nav">
50-
<a class="nav-item nav-link" href="/">Home</a>
51-
<a class="nav-item nav-link active" href="about.html">About</a>
52-
<a class="nav-item nav-link" href="projects.html">Projects</a>
53-
<li class="nav-item dropdown">
54-
<a class="nav-link dropdown-toggle" href="#" id="resume-dropdown" role="button" data-bs-toggle="dropdown" aria-expanded="false">
40+
<!-- Navbar nav items component.-->
41+
<div class="navbar-nav">
42+
<a class="nav-item nav-link" href="/">Home</a>
43+
<a class="nav-item nav-link active" href="about.html">About</a>
44+
<a class="nav-item nav-link" href="projects.html">Projects</a>
45+
<li class="nav-item dropdown">
46+
<a class="nav-link dropdown-toggle" href="#" id="resume-dropdown" role="button" data-bs-toggle="dropdown" aria-expanded="false">
5547
Resumes
5648
</a>
57-
<ul class="dropdown-menu" id="resume-dropdown-menu" aria-labelledby="resume-dropdown"></ul>
58-
</li>
59-
<a class="nav-item nav-link" href="contact.html">Contact</a>
60-
</div>
49+
<ul class="dropdown-menu" id="resume-dropdown-menu" aria-labelledby="resume-dropdown"></ul>
50+
</li>
51+
<a class="nav-item nav-link" href="contact.html">Contact</a>
52+
</div>
6153

62-
</nav>
54+
</nav>
6355

64-
</header>
6556

6657
<!-- Main content. -->
6758
<main class="p-5">

contact.html

Lines changed: 27 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -7,61 +7,51 @@
77
<meta charset="utf-8">
88
<meta name="viewport" content="width=device-width, initial-scale=1">
99

10-
<!-- Import core Bootstrap CSS. -->
10+
<!-- Document name. -->
11+
<title>Contact | David Read's Portfolio</title>
12+
13+
<!-- Import core Bootstrap library CSS and JS. -->
1114
<link href="https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-1BmE4kWBq78iYhFldvKuhfTAU6auU8tT94WrHftjDbrCEXSU1oBoqyl2QvZ6jIW3" crossorigin="anonymous">
15+
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/js/bootstrap.bundle.min.js" integrity="sha384-ka7Sk0Gln4gmtz2MlQnikT1wXgYsOg+OMhuP+IlRH9sENBO0LRn5q+8nbTov4+1p" crossorigin="anonymous"></script>
16+
17+
<!-- Import Font Awesome library JS. -->
18+
<script src="https://kit.fontawesome.com/b06b68bfd6.js" crossorigin="anonymous"></script>
19+
20+
<!-- Import jQuery library JS.-->
21+
<script src="js/jquery.js"></script>
1222

1323
<!-- Import developer CSS. -->
1424
<link href="css/global.css" rel="stylesheet">
1525
<link href="css/contact.css" rel="stylesheet">
1626

17-
<!-- Import jQuery JS.-->
18-
<script src="https://code.jquery.com/jquery-3.3.1.slim.min.js" integrity="sha384-q8i/X+965DzO0rT7abK41JStQIAqVgRVzpbzo5smXKp4YfRvH+8abtTE1Pi6jizo" crossorigin="anonymous"></script>
19-
20-
<!-- Import core Bootstrap JS. -->
21-
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/js/bootstrap.bundle.min.js" integrity="sha384-ka7Sk0Gln4gmtz2MlQnikT1wXgYsOg+OMhuP+IlRH9sENBO0LRn5q+8nbTov4+1p" crossorigin="anonymous"></script>
22-
23-
<!-- Import jQuery JS. -->
24-
<script src="js/jquery.js"></script>
25-
2627
<!-- Import developer JS. -->
2728
<script src="js/navbar.js"></script>
2829

29-
<!-- Import Font Awesome kit. -->
30-
<script src="https://kit.fontawesome.com/b06b68bfd6.js" crossorigin="anonymous"></script>
31-
32-
<!-- Document title. -->
33-
<title>Contact | David Read's Portfolio</title>
34-
3530
</head>
3631

3732
<body class="h-100 d-flex flex-column text-white">
3833

39-
<!-- Header. -->
40-
<header class="mb-auto p-3">
34+
<!-- Nav header. -->
35+
<nav class="mb-auto p-3 navbar navbar-expand-sm navbar-dark">
4136

42-
<!-- Navbar component. -->
43-
<nav class="navbar navbar-expand-sm navbar-dark">
37+
<!-- Navbar brand component. -->
38+
<span class="navbar-brand floa">David Read</span>
4439

45-
<!-- Navbar brand component. -->
46-
<span class="navbar-brand floa">David Read</span>
47-
48-
<!-- Navbar nav items component.-->
49-
<div class="navbar-nav">
50-
<a class="nav-item nav-link" href="/">Home</a>
51-
<a class="nav-item nav-link" href="about.html">About</a>
52-
<a class="nav-item nav-link" href="projects.html">Projects</a>
53-
<li class="nav-item dropdown">
54-
<a class="nav-link dropdown-toggle" href="#" id="resume-dropdown" role="button" data-bs-toggle="dropdown" aria-expanded="false">
40+
<!-- Navbar nav items component.-->
41+
<div class="navbar-nav">
42+
<a class="nav-item nav-link" href="/">Home</a>
43+
<a class="nav-item nav-link" href="about.html">About</a>
44+
<a class="nav-item nav-link" href="projects.html">Projects</a>
45+
<li class="nav-item dropdown">
46+
<a class="nav-link dropdown-toggle" href="#" id="resume-dropdown" role="button" data-bs-toggle="dropdown" aria-expanded="false">
5547
Resumes
5648
</a>
57-
<ul class="dropdown-menu" id="resume-dropdown-menu" aria-labelledby="resume-dropdown"></ul>
58-
</li>
59-
<a class="nav-item nav-link active" href="contact.html">Contact</a>
60-
</div>
61-
62-
</nav>
49+
<ul class="dropdown-menu" id="resume-dropdown-menu" aria-labelledby="resume-dropdown"></ul>
50+
</li>
51+
<a class="nav-item nav-link active" href="contact.html">Contact</a>
52+
</div>
6353

64-
</header>
54+
</nav>
6555

6656
<!-- Main content. -->
6757
<main class="p-5 text-center">

css/global.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ body {
22
background-color: #1C2128;
33
}
44

5-
header {
5+
nav {
66
background-color: #2D333B;
77
}
88

File renamed without changes.

index.html

Lines changed: 28 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -7,67 +7,58 @@
77
<meta charset="utf-8">
88
<meta name="viewport" content="width=device-width, initial-scale=1">
99

10-
<!-- Import core Bootstrap CSS. -->
10+
<!-- Document name. -->
11+
<title>Home | David Read's Portfolio</title>
12+
13+
<!-- Import core Bootstrap library CSS and JS. -->
1114
<link href="https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-1BmE4kWBq78iYhFldvKuhfTAU6auU8tT94WrHftjDbrCEXSU1oBoqyl2QvZ6jIW3" crossorigin="anonymous">
15+
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/js/bootstrap.bundle.min.js" integrity="sha384-ka7Sk0Gln4gmtz2MlQnikT1wXgYsOg+OMhuP+IlRH9sENBO0LRn5q+8nbTov4+1p" crossorigin="anonymous"></script>
16+
17+
<!-- Import Font Awesome library JS. -->
18+
<script src="https://kit.fontawesome.com/b06b68bfd6.js" crossorigin="anonymous"></script>
19+
20+
<!-- Import jQuery library JS.-->
21+
<script src="js/jquery.js"></script>
1222

1323
<!-- Import developer CSS. -->
1424
<link href="css/global.css" rel="stylesheet">
1525
<link href="css/index.css" rel="stylesheet">
1626

17-
<!-- Import jQuery JS.-->
18-
<script src="https://code.jquery.com/jquery-3.3.1.slim.min.js" integrity="sha384-q8i/X+965DzO0rT7abK41JStQIAqVgRVzpbzo5smXKp4YfRvH+8abtTE1Pi6jizo" crossorigin="anonymous"></script>
19-
20-
<!-- Import core Bootstrap JS. -->
21-
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/js/bootstrap.bundle.min.js" integrity="sha384-ka7Sk0Gln4gmtz2MlQnikT1wXgYsOg+OMhuP+IlRH9sENBO0LRn5q+8nbTov4+1p" crossorigin="anonymous"></script>
22-
23-
<!-- Import jQuery JS. -->
24-
<script src="js/jquery.js"></script>
25-
2627
<!-- Import developer JS. -->
2728
<script src="js/navbar.js"></script>
2829

29-
<!-- Import Font Awesome kit. -->
30-
<script src="https://kit.fontawesome.com/b06b68bfd6.js" crossorigin="anonymous"></script>
31-
32-
<!-- Document title. -->
33-
<title>Home | David Read's Portfolio</title>
34-
3530
</head>
3631

3732
<body class="h-100 d-flex flex-column text-white">
3833

39-
<!-- Header. -->
40-
<header class="mb-auto p-3">
41-
42-
<!-- Navbar component. -->
43-
<nav class="navbar navbar-expand-sm navbar-dark">
34+
<!-- Nav header. -->
35+
<nav class="mb-auto p-3 navbar navbar-expand-sm navbar-dark">
4436

45-
<!-- Navbar brand component. -->
46-
<span class="navbar-brand floa">David Read</span>
37+
<!-- Navbar brand component. -->
38+
<span class="navbar-brand floa">David Read</span>
4739

48-
<!-- Navbar nav items component.-->
49-
<div class="navbar-nav">
50-
<a class="nav-item nav-link active" href="/">Home</a>
51-
<a class="nav-item nav-link" href="about.html">About</a>
52-
<a class="nav-item nav-link" href="projects.html">Projects</a>
53-
<li class="nav-item dropdown">
54-
<a class="nav-link dropdown-toggle" href="#" id="resume-dropdown" role="button" data-bs-toggle="dropdown" aria-expanded="false">
40+
<!-- Navbar nav items component.-->
41+
<div class="navbar-nav">
42+
<a class="nav-item nav-link active" href="/">Home</a>
43+
<a class="nav-item nav-link" href="about.html">About</a>
44+
<a class="nav-item nav-link" href="projects.html">Projects</a>
45+
<li class="nav-item dropdown">
46+
<a class="nav-link dropdown-toggle" href="#" id="resume-dropdown" role="button" data-bs-toggle="dropdown" aria-expanded="false">
5547
Resumes
5648
</a>
57-
<ul class="dropdown-menu" id="resume-dropdown-menu" aria-labelledby="resume-dropdown"></ul>
58-
</li>
59-
<a class="nav-item nav-link" href="contact.html">Contact</a>
60-
</div>
49+
<ul class="dropdown-menu" id="resume-dropdown-menu" aria-labelledby="resume-dropdown"></ul>
50+
</li>
51+
<a class="nav-item nav-link" href="contact.html">Contact</a>
52+
</div>
6153

62-
</nav>
54+
</nav>
6355

64-
</header>
6556

6657
<!-- Main content. -->
6758
<main class="text-center p-5">
6859

6960
<!-- Profile pic. -->
70-
<img class="profile-pic mb-3" src="img/profile_pic.jpg" alt="Profile Picture of David Read">
61+
<img class="profile-pic mb-3" src="img/profile-pic.jpg" alt="Profile Picture of David Read">
7162

7263
<!-- Introduction text. -->
7364
<h3>Hello, there! My name is David.</h3>

projects.html

Lines changed: 27 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -7,62 +7,52 @@
77
<meta charset="utf-8">
88
<meta name="viewport" content="width=device-width, initial-scale=1">
99

10-
<!-- Import core Bootstrap CSS. -->
10+
<!-- Document name. -->
11+
<title>Projects | David Read's Portfolio</title>
12+
13+
<!-- Import core Bootstrap library CSS and JS. -->
1114
<link href="https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-1BmE4kWBq78iYhFldvKuhfTAU6auU8tT94WrHftjDbrCEXSU1oBoqyl2QvZ6jIW3" crossorigin="anonymous">
15+
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/js/bootstrap.bundle.min.js" integrity="sha384-ka7Sk0Gln4gmtz2MlQnikT1wXgYsOg+OMhuP+IlRH9sENBO0LRn5q+8nbTov4+1p" crossorigin="anonymous"></script>
16+
17+
<!-- Import Font Awesome library JS. -->
18+
<script src="https://kit.fontawesome.com/b06b68bfd6.js" crossorigin="anonymous"></script>
19+
20+
<!-- Import jQuery library JS.-->
21+
<script src="js/jquery.js"></script>
1222

1323
<!-- Import developer CSS. -->
1424
<link href="css/global.css" rel="stylesheet">
1525
<link href="css/projects.css" rel="stylesheet">
1626

17-
<!-- Import jQuery JS.-->
18-
<script src="https://code.jquery.com/jquery-3.3.1.slim.min.js" integrity="sha384-q8i/X+965DzO0rT7abK41JStQIAqVgRVzpbzo5smXKp4YfRvH+8abtTE1Pi6jizo" crossorigin="anonymous"></script>
19-
20-
<!-- Import core Bootstrap JS. -->
21-
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/js/bootstrap.bundle.min.js" integrity="sha384-ka7Sk0Gln4gmtz2MlQnikT1wXgYsOg+OMhuP+IlRH9sENBO0LRn5q+8nbTov4+1p" crossorigin="anonymous"></script>
22-
23-
<!-- Import jQuery JS. -->
24-
<script src="js/jquery.js"></script>
25-
2627
<!-- Import developer JS. -->
2728
<script src="js/navbar.js"></script>
2829
<script src="js/projects.js"></script>
2930

30-
<!-- Import Font Awesome kit. -->
31-
<script src="https://kit.fontawesome.com/b06b68bfd6.js" crossorigin="anonymous"></script>
32-
33-
<!-- Document title. -->
34-
<title>Projects | David Read's Portfolio</title>
35-
3631
</head>
3732

3833
<body class="h-100 d-flex flex-column text-white">
3934

40-
<!-- Header. -->
41-
<header class="mb-auto p-3">
35+
<!-- Nav header. -->
36+
<nav class="mb-auto p-3 navbar navbar-expand-sm navbar-dark">
4237

43-
<!-- Navbar component. -->
44-
<nav class="navbar navbar-expand-sm navbar-dark">
38+
<!-- Navbar brand component. -->
39+
<span class="navbar-brand floa">David Read</span>
4540

46-
<!-- Navbar brand component. -->
47-
<span class="navbar-brand floa">David Read</span>
48-
49-
<!-- Navbar nav items component.-->
50-
<div class="navbar-nav">
51-
<a class="nav-item nav-link" href="/">Home</a>
52-
<a class="nav-item nav-link" href="about.html">About</a>
53-
<a class="nav-item nav-link active" href="projects.html">Projects</a>
54-
<li class="nav-item dropdown">
55-
<a class="nav-link dropdown-toggle" href="#" id="resume-dropdown" role="button" data-bs-toggle="dropdown" aria-expanded="false">
41+
<!-- Navbar nav items component.-->
42+
<div class="navbar-nav">
43+
<a class="nav-item nav-link" href="/">Home</a>
44+
<a class="nav-item nav-link" href="about.html">About</a>
45+
<a class="nav-item nav-link active" href="projects.html">Projects</a>
46+
<li class="nav-item dropdown">
47+
<a class="nav-link dropdown-toggle" href="#" id="resume-dropdown" role="button" data-bs-toggle="dropdown" aria-expanded="false">
5648
Resumes
5749
</a>
58-
<ul class="dropdown-menu" id="resume-dropdown-menu" aria-labelledby="resume-dropdown"></ul>
59-
</li>
60-
<a class="nav-item nav-link" href="contact.html">Contact</a>
61-
</div>
62-
63-
</nav>
50+
<ul class="dropdown-menu" id="resume-dropdown-menu" aria-labelledby="resume-dropdown"></ul>
51+
</li>
52+
<a class="nav-item nav-link" href="contact.html">Contact</a>
53+
</div>
6454

65-
</header>
55+
</nav>
6656

6757
<!-- Main content. -->
6858
<main class="p-5">

0 commit comments

Comments
 (0)