Skip to content

Commit c371edb

Browse files
refactor: address comments
Signed-off-by: Stepan Bagritsevich <stefan@dragonflydb.io>
1 parent e0b9345 commit c371edb

File tree

6 files changed

+233
-488
lines changed

6 files changed

+233
-488
lines changed

src/core/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ cxx_test(sorted_map_test dfly_core redis_test_lib LABELS DFLY)
4949
cxx_test(bptree_set_test dfly_core LABELS DFLY)
5050
cxx_test(linear_search_map_test dfly_core LABELS DFLY)
5151
cxx_test(score_map_test dfly_core LABELS DFLY)
52-
cxx_test(maps_list_test dfly_core LABELS DFLY)
5352
cxx_test(flatbuffers_test dfly_core TRDP::flatbuffers LABELS DFLY)
5453
cxx_test(bloom_test dfly_core LABELS DFLY)
5554
cxx_test(allocation_tracker_test dfly_core absl::random_random LABELS DFLY)

src/core/linear_search_map.h

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ class LinearSearchMap : public absl::InlinedVector<std::pair<Key, Value>, N> {
5252

5353
Value& operator[](const Key& key);
5454
const Value& operator[](const Key& key) const;
55-
56-
std::vector<Key> keys() const;
5755
};
5856

5957
// Implementation
@@ -111,14 +109,4 @@ const Value& LinearSearchMap<Key, Value, N>::operator[](const Key& key) const {
111109
return find(key)->second;
112110
}
113111

114-
template <typename Key, typename Value, size_t N>
115-
std::vector<Key> LinearSearchMap<Key, Value, N>::keys() const {
116-
std::vector<Key> keys;
117-
keys.reserve(this->size());
118-
for (const auto& pair : *this) {
119-
keys.push_back(pair.first);
120-
}
121-
return keys;
122-
}
123-
124112
} // namespace dfly

src/core/maps_list.h

Lines changed: 0 additions & 293 deletions
This file was deleted.

0 commit comments

Comments
 (0)