-
Notifications
You must be signed in to change notification settings - Fork 423
Description
json_serializable disregards the page_width
setting in analysis_options.yaml
and uses the default value of 80. Therefore, if a different page_width
is specified in the project's analysis_options.yaml
, a separate formatting step is required after running build_runner build
.
json_serializable.dart/json_serializable/lib/src/json_part_builder.dart
Lines 113 to 114 in 83e7905
String defaultFormatOutput(String code, Version languageVersion) => | |
DartFormatter(languageVersion: languageVersion).format(code); |
Steps to Reproduce
This behavior can be reproduced in the json_serializable.dart
project.
- Set a
page_width
value other than 80 in/analysis_options.yaml
:formatter: page_width: 120
- Navigate to the
/example
. - Run
dart run build_runner build -d
.- The generated code is formatted with page_width
80
.
- The generated code is formatted with page_width
- Run
dart format lib/
.- The generated code is formatted with page_width
120
.
- The generated code is formatted with page_width
- Run
dart run build_runner build -d
.- The generated code is formatted with page_width
80
.
- The generated code is formatted with page_width
Proposal
How about adding the line // dart format width=80
to the generated code?
Trailing comma
As reported in #1486, the trailing commas option is also not reflected. However, since commas are removed when formatted with TrailingCommas.automate
, I cannot think of any cases where additional formatting would be necessary.