Skip to content

Conversation

toxaart
Copy link
Contributor

@toxaart toxaart commented Aug 22, 2025

Hi, please consider the following changes:

Jstack streaming output should be disabled in the test as JDK-8354461 suggest.

When disabled, the test does not hang with ZGC enabled.

Tested locally.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361370: runtime/Thread/TestThreadDumpMonitorContention.java fails due to time out on Windows (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26895/head:pull/26895
$ git checkout pull/26895

Update a local copy of the PR:
$ git checkout pull/26895
$ git pull https://git.openjdk.org/jdk.git pull/26895/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26895

View PR using the GUI difftool:
$ git pr show -t 26895

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26895.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2025

👋 Welcome back toxaart! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 22, 2025

@toxaart This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361370: runtime/Thread/TestThreadDumpMonitorContention.java fails due to time out on Windows

Reviewed-by: dholmes, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 123 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@alexmenkov, @dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Aug 22, 2025

@toxaart The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Aug 22, 2025
@toxaart toxaart marked this pull request as ready for review August 22, 2025 09:40
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 22, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 22, 2025
@stefank
Copy link
Member

stefank commented Aug 25, 2025

Thanks for adding the comment. I leave this up to the serviceability devs to finalize the review. Maybe @sspitsyn or @plummercj could help out given that they reviewed JDK-8354461.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussions in JBS this change to the test seems fine. Some minor edits on the comment needed.

Thanks.

Co-authored-by: David Holmes <62092539+dholmes-ora@users.noreply.github.com>
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Aug 26, 2025
@toxaart toxaart requested a review from dholmes-ora August 26, 2025 11:14
@toxaart
Copy link
Contributor Author

toxaart commented Sep 1, 2025

/integrate

@openjdk openjdk bot added ready Pull request is ready to be integrated sponsor Pull request is ready to be sponsored labels Sep 1, 2025
@openjdk
Copy link

openjdk bot commented Sep 1, 2025

@toxaart
Your change (at version 895a5d9) is now ready to be sponsored by a Committer.

@dholmes-ora
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 1, 2025

Going to push as commit 48f70d7.
Since your change was applied there have been 125 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 1, 2025
@openjdk openjdk bot closed this Sep 1, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 1, 2025
@openjdk
Copy link

openjdk bot commented Sep 1, 2025

@dholmes-ora @toxaart Pushed as commit 48f70d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants