From 37a9605c9247399502beaebb8bf4d7c653cb2583 Mon Sep 17 00:00:00 2001 From: Emmanuel Alves Date: Sun, 9 Mar 2025 16:22:28 -0400 Subject: [PATCH 1/2] fix: Deprecated: element.ref --- .changeset/fluffy-pumas-smile.md | 5 +++++ packages/utils/src/EventHandlers/wrapConnectorHooks.tsx | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/fluffy-pumas-smile.md diff --git a/.changeset/fluffy-pumas-smile.md b/.changeset/fluffy-pumas-smile.md new file mode 100644 index 000000000..9b61acf78 --- /dev/null +++ b/.changeset/fluffy-pumas-smile.md @@ -0,0 +1,5 @@ +--- +'@craftjs/utils': patch +--- + +Accessing element.ref is no longer supported. ref is now a regular prop. diff --git a/packages/utils/src/EventHandlers/wrapConnectorHooks.tsx b/packages/utils/src/EventHandlers/wrapConnectorHooks.tsx index 6b1727373..fe4603329 100644 --- a/packages/utils/src/EventHandlers/wrapConnectorHooks.tsx +++ b/packages/utils/src/EventHandlers/wrapConnectorHooks.tsx @@ -19,7 +19,7 @@ export function cloneWithRef( element: any, newRef: any ): React.ReactElement { - const previousRef = element.ref; + const previousRef = element.props.ref; invariant( typeof previousRef !== 'string', 'Cannot connect to an element with an existing string ref. ' + From 85f82eed7e33b7217698e4a776220e569900dd37 Mon Sep 17 00:00:00 2001 From: Emmanuel Alves Date: Wed, 12 Mar 2025 13:07:22 -0400 Subject: [PATCH 2/2] support backwards compatibility with the old input format --- packages/utils/src/EventHandlers/wrapConnectorHooks.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/utils/src/EventHandlers/wrapConnectorHooks.tsx b/packages/utils/src/EventHandlers/wrapConnectorHooks.tsx index fe4603329..f35f7cc92 100644 --- a/packages/utils/src/EventHandlers/wrapConnectorHooks.tsx +++ b/packages/utils/src/EventHandlers/wrapConnectorHooks.tsx @@ -19,7 +19,7 @@ export function cloneWithRef( element: any, newRef: any ): React.ReactElement { - const previousRef = element.props.ref; + const previousRef = element.props.ref || element.ref; invariant( typeof previousRef !== 'string', 'Cannot connect to an element with an existing string ref. ' +