Skip to content

Commit 9f1e32b

Browse files
authored
release notes script: keep not user facing rows (#2875)
Summary: We should keep the "not user facing" PRs in the draft release notes so that a human can go through them and verify they are actually not user facing. It's still easy to delete all of them from the generated file in a few seconds. Test Plan: Used this for v0.13.0 release notes formatting Reviewers: Subscribers: Tasks: Tags:
1 parent ba111b0 commit 9f1e32b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

scripts/clean_release_notes.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@
8989
"topic: performance": "Performance",
9090
"topic: documentation": "Documentation",
9191
"topic: for developer": "Developers",
92+
"topic: not user facing": "Not User Facing",
9293
}
9394

9495

@@ -123,6 +124,7 @@ def clean_release_notes():
123124
"Performance": [],
124125
"Documentation": [],
125126
"Developers": [],
127+
"Not User Facing": [],
126128
}
127129
with open(input_file, "r") as in_f, open(output_file, "a") as out_f:
128130
for line in in_f.readlines():
@@ -195,8 +197,6 @@ def get_commit_category(
195197
pr_number = parse_pr_number(commit_line)
196198
if pr_number in pr_number_to_label:
197199
label = pr_number_to_label[pr_number]
198-
if label == "topic: not user facing":
199-
return None
200200
if label in GITHUB_LABEL_TO_CATEGORY:
201201
return GITHUB_LABEL_TO_CATEGORY[label]
202202
elif any(x in commit_line.lower() for x in ["revert", "version.txt"]):

0 commit comments

Comments
 (0)