-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Open
Labels
area/arcIssue related to ARC (dependency injection)Issue related to ARC (dependency injection)
Description
Beans#getCallbacks()
is called several times, as part of generating the bean bytecode support code and also as part of BeanInfo#hasDestroyLogic()
.
Moreover, I suspect collectCallbacks
could be optimized by getting the AnnotationInstance
s for the whole class instead of testing each method separately.
So two things:
- Should these callbacks be part of
BeanInfo
orBeanDeployment
and collected once and for all? - Iterating over all the methods is probably a bad idea given we have Jandex around and it can get us all the class annotations in one go i.e. use
ClassInfo#annotations(DotName name)
.
I'm not doing this now as @Ladicek is working on rewriting ArC to Gizmo 2 so I prefer not be in his way. It's probably worth some discussion for the first item anyway.
Metadata
Metadata
Assignees
Labels
area/arcIssue related to ARC (dependency injection)Issue related to ARC (dependency injection)