From c0b18626e56bd8053578d8ef31ebb2cdccfeff68 Mon Sep 17 00:00:00 2001 From: Eric Cunningham Date: Mon, 6 Jan 2025 18:48:15 -0800 Subject: [PATCH 1/5] Update node.rb required transitive.rb, so it can be found. I recently tried to use REXML::Formatters::Transitive, and its not included in REXML. --- lib/rexml/node.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/rexml/node.rb b/lib/rexml/node.rb index c771db70..d8af43e1 100644 --- a/lib/rexml/node.rb +++ b/lib/rexml/node.rb @@ -2,6 +2,7 @@ require_relative "parseexception" require_relative "formatters/pretty" require_relative "formatters/default" +require_relative "formatters/transitive" module REXML # Represents a node in the tree. Nodes are never encountered except as From 45613f3a8a434ffa87527e105c472eac7d4e706b Mon Sep 17 00:00:00 2001 From: Eric Cunningham Date: Fri, 10 Jan 2025 12:15:14 -0800 Subject: [PATCH 2/5] Update document.rb remove require transitive Removing require Transitive as advised. --- lib/rexml/document.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/rexml/document.rb b/lib/rexml/document.rb index d1747dd4..24e328ca 100644 --- a/lib/rexml/document.rb +++ b/lib/rexml/document.rb @@ -388,7 +388,6 @@ def write(*arguments) end formatter = if indent > -1 if transitive - require_relative "formatters/transitive" REXML::Formatters::Transitive.new( indent, ie_hack ) else REXML::Formatters::Pretty.new( indent, ie_hack ) From d4e33962c4792c6346c652084052ce4d7bb2558f Mon Sep 17 00:00:00 2001 From: Eric Cunningham Date: Fri, 10 Jan 2025 12:16:10 -0800 Subject: [PATCH 3/5] Update document.rb --- lib/rexml/document.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/rexml/document.rb b/lib/rexml/document.rb index 24e328ca..ce3ea26a 100644 --- a/lib/rexml/document.rb +++ b/lib/rexml/document.rb @@ -388,6 +388,7 @@ def write(*arguments) end formatter = if indent > -1 if transitive + REXML::Formatters::Transitive.new( indent, ie_hack ) else REXML::Formatters::Pretty.new( indent, ie_hack ) From 2a4d0ecd0ff3b8066f93d7a1e6858f7c1e40ee6a Mon Sep 17 00:00:00 2001 From: Eric Cunningham Date: Fri, 10 Jan 2025 12:21:42 -0800 Subject: [PATCH 4/5] Update node.rb Eliminating require transitive as advised --- lib/rexml/node.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/rexml/node.rb b/lib/rexml/node.rb index d8af43e1..c771db70 100644 --- a/lib/rexml/node.rb +++ b/lib/rexml/node.rb @@ -2,7 +2,6 @@ require_relative "parseexception" require_relative "formatters/pretty" require_relative "formatters/default" -require_relative "formatters/transitive" module REXML # Represents a node in the tree. Nodes are never encountered except as From e550d1319d42ea445c19c2e1cbc471c726df59e9 Mon Sep 17 00:00:00 2001 From: Eric Cunningham Date: Fri, 10 Jan 2025 12:26:05 -0800 Subject: [PATCH 5/5] Update element.rb --- lib/rexml/element.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rexml/element.rb b/lib/rexml/element.rb index 4e3a60b9..8cd23306 100644 --- a/lib/rexml/element.rb +++ b/lib/rexml/element.rb @@ -1505,7 +1505,7 @@ def write(output=$stdout, indent=-1, transitive=false, ie_hack=false) Kernel.warn("#{self.class.name}.write is deprecated. See REXML::Formatters", uplevel: 1) formatter = if indent > -1 if transitive - require_relative "formatters/transitive" + require_relative "formatters/transitive" REXML::Formatters::Transitive.new( indent, ie_hack ) else REXML::Formatters::Pretty.new( indent, ie_hack )