Skip to content

Commit 96a1e8f

Browse files
fix: update internal registry from legacy to new revamp registry (#317)
## Problem The release creation process was failing with 404 errors when trying to fetch images like cadvisor:6.6.2517 from the legacy internal registry. ## Root Cause Recent changes in the main sourcegraph repo migrated from legacy registries to new 'revamp' registries, but the deploy repos were still hardcoded to use the old registry. ## Solution - Replace `us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal` with `us-docker.pkg.dev/sourcegraph-images/internal` - Updated both release.yaml and batch-change/release.yaml - Tested and confirmed images exist in the new registry ## Test Plan - Validated that cadvisor:6.6.2517 exists in new registry but not in old registry - Successfully tested sg ops update-images command with new registry - Confirmed this fixes the original 404 errors during release creation Co-authored-by: Amp <amp@ampcode.com>
1 parent 96e349c commit 96a1e8f

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

batch-change/release.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ internal:
3434
set -eu
3535
sg ops update-images \
3636
--kind k8s \
37-
--registry us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal \
37+
--registry us-docker.pkg.dev/sourcegraph-images/internal \
3838
--docker-username=$DOCKER_USERNAME \
3939
--docker-password=$DOCKER_PASSWORD \
4040
--pin-tag {{inputs.server.tag}} \
@@ -44,7 +44,7 @@ internal:
4444
set -eu
4545
sg ops update-images \
4646
--kind k8s \
47-
--registry us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal \
47+
--registry us-docker.pkg.dev/sourcegraph-images/internal \
4848
--docker-username=$DOCKER_USERNAME \
4949
--docker-password=$DOCKER_PASSWORD \
5050
--pin-tag {{inputs.server.tag}} \
@@ -55,7 +55,7 @@ internal:
5555
set -eu
5656
sg ops update-images \
5757
--kind k8s \
58-
--registry us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal \
58+
--registry us-docker.pkg.dev/sourcegraph-images/internal \
5959
--docker-username=$DOCKER_USERNAME \
6060
--docker-password=$DOCKER_PASSWORD \
6161
--pin-tag {{inputs.server.tag}} \
@@ -65,7 +65,7 @@ internal:
6565
set -eu
6666
sg ops update-images \
6767
--kind k8s \
68-
--registry us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal \
68+
--registry us-docker.pkg.dev/sourcegraph-images/internal \
6969
--docker-username=$DOCKER_USERNAME \
7070
--docker-password=$DOCKER_PASSWORD \
7171
--pin-tag {{inputs.server.tag}} \
@@ -76,7 +76,7 @@ internal:
7676
set -eu
7777
sg ops update-images \
7878
--kind k8s \
79-
--registry us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal \
79+
--registry us-docker.pkg.dev/sourcegraph-images/internal \
8080
--docker-username=$DOCKER_USERNAME \
8181
--docker-password=$DOCKER_PASSWORD \
8282
--pin-tag {{inputs.server.tag}} \
@@ -86,7 +86,7 @@ internal:
8686
set -eu
8787
sg ops update-images \
8888
--kind k8s \
89-
--registry us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal \
89+
--registry us-docker.pkg.dev/sourcegraph-images/internal \
9090
--docker-username=$DOCKER_USERNAME \
9191
--docker-password=$DOCKER_PASSWORD \
9292
--pin-tag {{inputs.server.tag}} \

release.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ internal:
3434
set -eu
3535
sg ops update-images \
3636
--kind k8s \
37-
--registry us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal \
37+
--registry us-docker.pkg.dev/sourcegraph-images/internal \
3838
--docker-username=$DOCKER_USERNAME \
3939
--docker-password=$DOCKER_PASSWORD \
4040
--pin-tag {{inputs.server.tag}} \
@@ -44,7 +44,7 @@ internal:
4444
set -eu
4545
sg ops update-images \
4646
--kind k8s \
47-
--registry us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal \
47+
--registry us-docker.pkg.dev/sourcegraph-images/internal \
4848
--docker-username=$DOCKER_USERNAME \
4949
--docker-password=$DOCKER_PASSWORD \
5050
--pin-tag {{inputs.server.tag}} \
@@ -83,7 +83,7 @@ internal:
8383
set -eu
8484
sg ops update-images \
8585
--kind k8s \
86-
--registry us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal \
86+
--registry us-docker.pkg.dev/sourcegraph-images/internal \
8787
--docker-username=$DOCKER_USERNAME \
8888
--docker-password=$DOCKER_PASSWORD \
8989
--pin-tag {{inputs.server.tag}} \
@@ -93,7 +93,7 @@ internal:
9393
set -eu
9494
sg ops update-images \
9595
--kind k8s \
96-
--registry us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal \
96+
--registry us-docker.pkg.dev/sourcegraph-images/internal \
9797
--docker-username=$DOCKER_USERNAME \
9898
--docker-password=$DOCKER_PASSWORD \
9999
--pin-tag {{inputs.server.tag}} \
@@ -130,7 +130,7 @@ internal:
130130
set -eu
131131
sg ops update-images \
132132
--kind k8s \
133-
--registry us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal \
133+
--registry us-docker.pkg.dev/sourcegraph-images/internal \
134134
--docker-username=$DOCKER_USERNAME \
135135
--docker-password=$DOCKER_PASSWORD \
136136
--pin-tag {{inputs.server.tag}} \
@@ -140,7 +140,7 @@ internal:
140140
set -eu
141141
sg ops update-images \
142142
--kind k8s \
143-
--registry us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal \
143+
--registry us-docker.pkg.dev/sourcegraph-images/internal \
144144
--docker-username=$DOCKER_USERNAME \
145145
--docker-password=$DOCKER_PASSWORD \
146146
--pin-tag {{inputs.server.tag}} \

0 commit comments

Comments
 (0)