-
Notifications
You must be signed in to change notification settings - Fork 41.4k
Open
Description
Continuation of #46587.
- Review 27c96d9
- Run IntelliJ IDEA null checks and fix issues
- Remove varargs checkstyle suppressions (needs release of https://github.com/spring-io/spring-javaformat)
- Add nullability to
org.springframework.boot.json.JsonWriter
(it's currently@NullUnmarked
) - Check public API of modules if
@Nullable
is missing (especially if generics are involved) - Remove suppression in graphql module once Missing @Nullable annotation on GraphiQlHandler spring-graphql#1276 is fixed
- Review
@SuppressWarnings("NullAway")
suppressions - Review
org.springframework.boot.hibernate.SpringJtaPlatform#locateTransactionManager
andorg.springframework.boot.hibernate.SpringJtaPlatform#locateUserTransaction
- Review if
org.springframework.boot.metrics.autoconfigure.export.properties.PropertiesConfigAdapter.Getter
is fine for us. - Take another look at
org.springframework.boot.context.properties.PropertyMapper
, especiallyalwaysApplyingWhenNonNull
andwhenNonNull
. - Review
Mono.from(null)
inorg.springframework.boot.webflux.actuate.endpoint.web.AbstractWebFluxEndpointHandlerMapping.ReactiveWebOperationAdapter#handleResult
- Review
Mono.error(getError(request)))
inorg.springframework.boot.webflux.autoconfigure.error.DefaultErrorWebExceptionHandler#renderErrorView
- Review
org.springframework.boot.ResourceBanner#createNullDefaultSources
. Eventually aMapPropertySource
from a map containingnull
values is created, which shouldn't be possible according to the annotations onMapPropertySource
. - Review
org.springframework.boot.context.properties.source.MapConfigurationPropertySource#put
. It puts anull
key inthis.source
, which is then used withMapPropertySource
, which doesn't accept null keys (at least according to the annotations). - Depending on
SingletonSupplier
is not singleton ifnull
is returned on first supplier call spring-framework#35369: Refactor SingletonSupplier usages to only use them with non-nullable suppliers - Review
org.springframework.boot.test.json.JsonContentAssert#compare(java.lang.CharSequence, org.skyscreamer.jsonassert.JSONCompareMode)
when passingnull
as first parameter
sdeleuze
Metadata
Metadata
Assignees
Labels
type: enhancementA general enhancementA general enhancement