fix(tests): Make tests pass with cargo test (#23520)

* Fix tests failing with cargo test

* Use tokio Mutex instead

* Implement global lock as suggested in PR review

* Fix clippy

* Drop guard after binding

* Rename wait_for_tcp->wait_for_tcp_and_release

* Lock when using log_schema in tests

* Lock in tracing-limit's tests due to tracing::subcriber::with_default

* Revert "Lock when using log_schema in tests"

This reverts commit eed7a3878a5c0c74b3e759c8c470d42b353964d7.

---------

Co-authored-by: Pavlos Rontidis <pavlos.rontidis@gmail.com>

Author: thomasqueirozb

lib/portpicker/src/lib.rs

@@ -94,6 +94,28 @@ pub fn pick_unused_port(ip: IpAddr) -> Port {
     }
 }
 
+pub fn bind_unused_udp(ip: IpAddr) -> UdpSocket {
+    let mut rng = rng();
+
+    loop {
+        // Try random port first
+        for _ in 0..10 {
+            let port = rng.random_range(15000..25000);
+
+            if let Ok(socket) = UdpSocket::bind(SocketAddr::new(ip, port)) {
+                return socket;
+            }
+        }
+
+        // Ask the OS for a port
+        for _ in 0..10 {
+            if let Ok(socket) = UdpSocket::bind(SocketAddr::new(ip, 0)) {
+                return socket;
+            }
+        }
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use std::net::{IpAddr, Ipv4Addr, Ipv6Addr};

lib/tracing-limit/src/lib.rs

@@ -445,13 +445,15 @@ impl Visit for MessageVisitor {
 #[cfg(test)]
 mod test {
     use std::{
-        sync::{Arc, Mutex},
+        sync::{Arc, LazyLock, Mutex},
         time::Duration,
     };
 
     use mock_instant::global::MockClock;
     use tracing_subscriber::layer::SubscriberExt;
 
+    static TRACING_DEFAULT_LOCK: LazyLock<Mutex<()>> = LazyLock::new(|| Mutex::new(()));
+
     use super::*;
 
     #[derive(Default)]
@@ -494,6 +496,8 @@ mod test {
 
     #[test]
     fn rate_limits() {
+        let _guard = TRACING_DEFAULT_LOCK.lock().unwrap();
+
         let events: Arc<Mutex<Vec<String>>> = Default::default();
 
         let recorder = RecordingLayer::new(Arc::clone(&events));
@@ -527,6 +531,8 @@ mod test {
 
     #[test]
     fn override_rate_limit_at_callsite() {
+        let _guard = TRACING_DEFAULT_LOCK.lock().unwrap();
+
         let events: Arc<Mutex<Vec<String>>> = Default::default();
 
         let recorder = RecordingLayer::new(Arc::clone(&events));
@@ -564,6 +570,8 @@ mod test {
 
     #[test]
     fn rate_limit_by_span_key() {
+        let _guard = TRACING_DEFAULT_LOCK.lock().unwrap();
+
         let events: Arc<Mutex<Vec<String>>> = Default::default();
 
         let recorder = RecordingLayer::new(Arc::clone(&events));
@@ -628,6 +636,8 @@ mod test {
 
     #[test]
     fn rate_limit_by_event_key() {
+        let _guard = TRACING_DEFAULT_LOCK.lock().unwrap();
+
         let events: Arc<Mutex<Vec<String>>> = Default::default();
 
         let recorder = RecordingLayer::new(Arc::clone(&events));

src/sources/exec/tests.rs

@@ -331,6 +331,7 @@ async fn test_drop_receiver() {
 
 #[tokio::test]
 #[cfg(unix)]
+#[cfg_attr(target_os = "macos", ignore)] // Flaky when running `cargo test`
 async fn test_run_command_linux() {
     let config = standard_scheduled_test_config();