fix(swc-angular-plugin): make lifetime explicit in parse_query_prop_info return type

yharaskrik · yharaskrik · commit 122590dff316 · 2025-08-24T07:30:33.000-07:00
Rust CI is failing to build jscutlery#802. The function `parse_query_prop_info` returned `AngularPropInfo` with an elided lifetime, while the input `&ClassProp` provided the borrow. This inconsistency triggered the lint. Updated the return type to `AngularPropInfo<'_>` to explicitly tie the lifetime of the returned value to the input borrow, removing the warning and unifying local and CI builds. This makes the lifetime contract explicit.
diff --git a/packages/swc-angular-plugin/src/component_property_visitor/query_prop_parser.rs b/packages/swc-angular-plugin/src/component_property_visitor/query_prop_parser.rs
@@ -37,7 +37,7 @@ impl AngularPropParser for QueryPropParser {
 }
 
 impl QueryPropParser {
-    fn parse_query_prop_info(class_prop: &ClassProp) -> Option<(QueryType, AngularPropInfo)> {
+    fn parse_query_prop_info(class_prop: &ClassProp) -> Option<(QueryType, AngularPropInfo<'_>)> {
         /* `viewChild` & `viewChildren` are probably more frequently used so let's
          * try to parse them first. */
         if let Some(prop_info) = parse_angular_prop(class_prop, "viewChild") {

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ impl AngularPropParser for QueryPropParser {`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`impl QueryPropParser {`
`40`		`- fn parse_query_prop_info(class_prop: &ClassProp) -> Option<(QueryType, AngularPropInfo)> {`
	`40`	`+ fn parse_query_prop_info(class_prop: &ClassProp) -> Option<(QueryType, AngularPropInfo<'_>)> {`
`41`	`41`	/* `viewChild` & `viewChildren` are probably more frequently used so let's
`42`	`42`	`* try to parse them first. */`
`43`	`43`	`if let Some(prop_info) = parse_angular_prop(class_prop, "viewChild") {`