-
Notifications
You must be signed in to change notification settings - Fork 16
Firefly-1815: upload a file via an action, usually firefly_client #1825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great!!! ❤️
I tested it out from python and it works well for both immediate and non-immediate case. Now I can easily write a generic function for the python client using this.
Code looks good - error handling needs some polishing (see my comments).
I noticed a bug with menu tabs switching which I remember used to exist but is now more noticeable with subsequent uploads:
- Do
fc.dispatch('app_data.externalUpload', {'fileOnServer':key, 'displayName':os.path.basename(file)})
, firefly client will open the "Upload" tab with preloaded file option. Now without changing anything in UI, dofc.dispatch('app_data.externalUpload', {'immediate':True, 'fileOnServer':key, 'displayName':os.path.basename(file)})
, firefly client will take you to Results page but the tab remains stuck at "Upload". You can ofc fix it by clicking on "Results" tab but it's odd behavior since the UI now has a tab view (I know results is still a dropdown in our logic). - The same bug can be reproduced for other firefly_client functions too: Open firefly client, go to any tab other than results (let's say "Images"), and then do
fc.show_fits(plot_id="wise-fullimage", URL='http://irsa.ipac.caltech.edu/ibe/data/wise/allsky/4band_p1bm_frm/6a/02206a/149/02206a149-w1-int-1b.fits')
, it will show "Results" page but tab will remain stuck at "Images" until you manually click the "Results"
Can firefly be made globally aware that if any externally dispatched action opens Results page, also change the tab to "Results"? (This can probably be separated in another ticket)
I will see it I can fix it in this ticket. Otherwise I will make a new one. |
5d022a8
to
50f330f
Compare
- includes clean up and response to feedback
50f330f
to
434abe1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error messaging updates look good - the info popup is helpful. I also tested the issue I reported with tabs not switching correctly - it's fixed now.
Also the URL API with load
command is a great addition!
Firefly-1815: Upload via a action, usually from firefly_client
Testing From Python firefly_client
firefly_client
Test loading to the upload panel
Test immediate loading, change last line to add
'immediate':True
Test a url
Testing URL API