Implement BaseFileNode for azure blob storage #11255
Conversation
|
@futa-ikeda could you please help review this BaseFileNode implementation for azure blob storage? |
|
Yes, can do! Similar to the GravyValet PR, I can take a look, but will request help from @adlius as he will have better insight into this |
There was a problem hiding this comment.
This all seems reasonable to me, though I'm not familiar with the backend implementation needed for addons, so I will not be leaving an approval or request for changes. It seems there are things in the other addon directories that may not be needed anymore now that we are using GravyValet to communicate to addons, but I'm not familiar with what those are
There was a problem hiding this comment.
LGTM. Do we need review from @adlius or @opaduchak ? If not, I'm happy to merge it.
I spoke to @adlius last week and I think after that conversation, it would be fine for you to merge if you think it is good to go, @felliott |
felliott
merged commit 664ec76
into
CenterForOpenScience:feature/azure-blob-storage
Purpose
Implement BaseFileNode for azure blob storage so that the addon view can successfully resolve file class and redirect request
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
NII Implementing Features in Legacy OSF Add-ons using BaseFileNode for hackason
#49