[ENG-8552] Investigate fix probablisic test fail #11259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests are passed on my local branch |
Johnetordoff
approved these changes
Aug 25, 2025
There was a problem hiding this comment.
@antkryt This seems right, but put a written explanation of why you think is effecting the tests at certain times and not others in the ticket, but otherwise looks good.
|
@antkryt Pull in the latest changes to fix your failing test and I can merge it. |
Johnetordoff
merged commit 7cdebec
into
CenterForOpenScience:feature/pbs-25-16
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
fix flaky test_serialized_metadata
Changes
QA Notes
Documentation
Side Effects
I'm 95% sure that my PR will fix the issue, but still need to monitor to see if this test fails
Ticket
https://openscience.atlassian.net/browse/ENG-8552