Adjust result builder to not return incomplete data from the entity store #8595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
Closes #5256 (in this specific format)
Closes #8290
Probably also #5477
Background:
It was possible that Strawberry Shake returned incomplete data from the entity store when an entity referenced itself but each reference had a different selection set.
For example, consider this query:
Since the person is selfish, its best friend is him-/herself.
Because the entity store is filled recursively, the bestFriend selection set is evaluated first, writing
firstName
,age
, andphone
to the entity store for id"1"
. However, after that the selfishGuy selection set is evaluated and overwrites the entity store entry for"1"
with the values ofid
,firstName
,lastName
, and thebestFriend
-id. As a resultage
andphone
are lost.This PR fixes the issue by rechecking whether the entity is already present in the store after evaluating the arguments required to create the entity at the current hierarchy level. Therefore, no fields are lost and the entity store is filled correctly. In fact, it is populated step-by-step.
Core change (the args were inlined before):