Improve module typing and add match-newline-at-toplevel feature #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project's dependency management has been completely overhauled. Files associated with the old system (like .travis.yml, Pipfile, setup.cfg, and setup.py) have been deleted. A new pyproject.toml file, which is used by the poetry tool, has been added.
…ions The .gitignore file has been greatly expanded to include files and directories created by a variety of tools and configurations used in Python development. It now covers everything from byte-compiled files, distribution packaging, unit test reports, to dependency lock files and environment settings.
This change includes the addition of noxfile.py, setting up sessions for running tests, linters, type checking, and code formatting.
|
Thanks for the PR! It's quite large 😅 If you want to break out the match-newline-at-toplevel feature into a separate PR, I'd love to take a look and merge that. I'm also happy to look at some of these changes individually (as separate PRs), but I won't merge in all of these changes. In particular, I'm not keen to break existing APIs (e.g., by renaming the base class used by exceptions). |
|
Hi Chris, thank you for your comment.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced rewrite method with match-newline-at-toplevel flag, added corresponding test case, specified type annotations, transitioned to Poetry, and integrated Nox for linting, formatting, and testing.