-
Notifications
You must be signed in to change notification settings - Fork 71
Some additional accessibility test coverage #2823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jonathanmos
merged 2 commits into
develop
from
jmoskovich/additional-accessibilty-coverage
Aug 26, 2025
Merged
Some additional accessibility test coverage #2823
jonathanmos
merged 2 commits into
develop
from
jmoskovich/additional-accessibilty-coverage
Aug 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2823 +/- ##
===========================================
- Coverage 70.03% 70.01% -0.01%
===========================================
Files 845 845
Lines 31497 31467 -30
Branches 5283 5286 +3
===========================================
- Hits 22056 22031 -25
+ Misses 7962 7957 -5
Partials 1479 1479
🚀 New features to boost your workflow:
|
c26989a
to
aedbf98
Compare
0xnm
reviewed
Aug 19, 2025
...sdk-android-rum/src/test/kotlin/com/datadog/android/rum/internal/domain/RumDataWriterTest.kt
Outdated
Show resolved
Hide resolved
aedbf98
to
2b7e1eb
Compare
ambushwork
previously approved these changes
Aug 26, 2025
0xnm
reviewed
Aug 26, 2025
...m/src/main/kotlin/com/datadog/android/rum/internal/domain/accessibility/AccessibilityInfo.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/datadog/android/rum/internal/domain/accessibility/AccessibilitySnapshotManager.kt
Outdated
Show resolved
Hide resolved
2b7e1eb
to
aa79b82
Compare
0xnm
approved these changes
Aug 26, 2025
ambushwork
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor
DefaultAccessibilitySnapshotManager
to return a nullable object - this simplifies the later logic in terms of knowing if anything changed in the accessibility state.Adds some additional test coverage for accessibility around the logic for view reduction
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)