Skip to content

added region and district fields #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

added region and district fields #272

wants to merge 2 commits into from
+6 −1

Conversation

lkris2uic
Copy link

Solves #264

  • Branch: feature/add-region-district
  • This pull request adds the region and district fields to the Company contact details fieldsets section in the following classes:
crm.site.leadadmin.LeadAdmin

crm.admin.LeadAdmin
  • Closes: Add the region and district fields to the 'Company contact details' fieldsets section in LeadAdmin classes.
Ran 182 tests in 17.579s

OK (skipped=4)

@DjangoCRM DjangoCRM added enhancement New feature or request needs review Pull requests that require code review and approval python Pull requests that update python code labels Aug 24, 2025
@DjangoCRM
Copy link
Owner

Hi @lkris2uic. Thanks for PR!
File 'crm/site/leadadmin.py' is ok.
In file 'crm/admin.py' , the fields was added to wrong class.

@DjangoCRM DjangoCRM added the requires changes Pull requests that need to be updated based on reviewers' comments and then reviewed again label Aug 25, 2025
@lkris2uic
Copy link
Author

Hi @DjangoCRM

Thanks for bringing that up. I have updated the changes. It should be visible to you now

@DjangoCRM DjangoCRM added invalid This doesn't seem right and removed needs review Pull requests that require code review and approval requires changes Pull requests that need to be updated based on reviewers' comments and then reviewed again labels Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request invalid This doesn't seem right python Pull requests that update python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkris2uic @DjangoCRM