When correcting yamsql metrics, only update queries with differences #3547
+246
−158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, if you add a new query and run the test with CORRECT_METRICS, it will update all the timings for all of the other queries. This is less important for the binp, but can make it hard to look at the metrics yaml diff, as there will be many lines to ignore. With this change, it will keep the original info for every query that did not result in a diffence. I tested this locally by adding a new query to standard-tests.yamsql and seeing that when I correct the metrics, only the one in question is modified, and the rest stay the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, if you add a new query and run the test with CORRECT_METRICS, it will update all the timings for all of the other queries. This is less important for the binp, but can make it hard to look at the metrics yaml diff, as there will be many lines to ignore.
With this change, it will keep the original info for every query that did not result in a diffence.
I tested this locally by adding a new query to standard-tests.yamsql and seeing that when I correct the metrics, only the one in question is modified, and the rest stay the same.
Here is an example diff without this change: ScottDugas@8f0778f
And here is an example diff with it: ScottDugas@0253892