Skip to content

Conversation

cfloress
Copy link
Contributor

@cfloress cfloress commented Aug 21, 2025

feat(genai): Add samples for Tools, Embeddings, Provisioned Throughput and Text-generation

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@cfloress cfloress requested review from a team as code owners August 21, 2025 22:36
Copy link

snippet-bot bot commented Aug 21, 2025

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 21, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @cfloress, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the Go samples for the Google GenAI SDK. It introduces new examples covering key functionalities such as generating text embeddings for document retrieval, demonstrating text generation with provisioned throughput, implementing chat-based text generation with history, and showcasing the use of Vertex AI Search as a tool for grounded content generation. These additions provide comprehensive guides for developers looking to leverage the GenAI SDK for various AI-powered applications.

Highlights

  • Text Embeddings: A new Go sample has been added to demonstrate how to generate text embeddings for document retrieval using the Gemini-embedding model.
  • Provisioned Throughput: A new Go sample has been introduced to showcase text generation with provisioned throughput, allowing for dedicated model capacity.
  • Chat-based Text Generation: A new Go sample illustrates how to perform chat-based text generation, including managing and utilizing chat history.
  • Vertex AI Search Integration: A new Go sample demonstrates the integration of Vertex AI Search as a tool for grounded text generation, enhancing response accuracy and relevance.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several new samples for the GenAI SDK. My review focuses on correctness and best practices. I've found some critical issues in the provisioned throughput and chat generation samples that make them incorrect or non-functional. Specifically, the provisioned throughput sample uses the wrong settings for both the request type and model name, effectively not demonstrating the feature at all. The chat sample has a compilation error in how it constructs a message part. I've also included several medium-severity suggestions to improve code quality by using constants for magic values and clarifying the purpose of certain fields.

@glasnt
Copy link
Contributor

glasnt commented Aug 21, 2025

Hi! I'm not sure if you meant to open three duplicate PRs; if this was made in error, please close this PR and focus development on the earlier #5370. Thanks in advance!

@cfloress cfloress closed this Aug 25, 2025
@cfloress cfloress reopened this Aug 25, 2025
@msampathkumar msampathkumar added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 25, 2025
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 25, 2025
@msampathkumar msampathkumar added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 29, 2025
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 29, 2025
Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor nit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants