-
-
Notifications
You must be signed in to change notification settings - Fork 880
Add support for primary Imports/Exports #3089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I know this is still a draft but I'll just give a little in-progress feedback while I'm checking it out:
|
31ec372
to
82c9083
Compare
Performance Benchmark Results
|
Self::Error("no source") | ||
} | ||
} | ||
// /// Represents the result of a type query for an input or output connector. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be deleted?
@@ -6590,49 +6659,6 @@ struct InputTransientMetadata { | |||
// types: populated for each protonode after each | |||
} | |||
|
|||
// TODO: Eventually remove this migration document upgrade code | |||
fn migrate_output_names<'de, D: serde::Deserializer<'de>>(deserializer: D) -> Result<Vec<String>, D::Error> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this moved elsewhere (that I can't find) or has it been fully removed? Unless its purpose has been obviated, we do still need these migrations.
Enables modifying the exposed primary input/output