Skip to content

Conversation

adamgerhant
Copy link
Collaborator

Enables modifying the exposed primary input/output

@Keavon
Copy link
Member

Keavon commented Aug 27, 2025

I know this is still a draft but I'll just give a little in-progress feedback while I'm checking it out:

  • The primary imports should have its reorder handle removed.
  • There should be a horizontal line drawn between the primary import and the secondary imports.

@adamgerhant adamgerhant force-pushed the rework-imports-exports branch from 31ec372 to 82c9083 Compare August 28, 2025 06:09
@adamgerhant adamgerhant marked this pull request as ready for review August 28, 2025 06:11
Copy link

Performance Benchmark Results

🔧 Graph Compilation

compile_demo_art_iai::compile_group::compile_to_proto with_setup_0:load_from_name(isometric-fountain)
Instructions: 22,889,446 (master) → 22,825,002 (HEAD) : $$\color{lime}-0.28\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     287,361|    287,494          +0.05%
D1mw                      78,884|     79,345          +0.58%
DLmr                      28,662|     28,002          -2.30%
DLmw                      42,185|     42,880          +1.65%
Dr                     5,685,948|  5,665,452          -0.36%
Dw                     3,956,490|  3,942,748          -0.35%
EstimatedCycles       36,336,792| 36,270,344          -0.18%
I1mr                      47,397|     54,569         +15.13%
ILmr                         831|        835          +0.48%
Ir                    22,889,446| 22,825,002          -0.28%
L1hits                32,118,242| 32,011,794          -0.33%
LLhits                   341,964|    349,691          +2.26%
RamHits                   71,678|     71,717          +0.05%
TotalRW               32,531,884| 32,433,202          -0.30%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_1:load_from_name(painted-dreams)
Instructions: 12,191,014 (master) → 12,142,116 (HEAD) : $$\color{lime}-0.40\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     147,223|    145,898          -0.90%
D1mw                      41,841|     41,521          -0.76%
DLmr                         697|        537         -22.96%
DLmw                      14,490|     12,726         -12.17%
Dr                     3,011,819|  2,998,199          -0.45%
Dw                     2,095,590|  2,086,516          -0.43%
EstimatedCycles       18,624,343| 18,500,443          -0.67%
I1mr                      23,271|     26,329         +13.14%
ILmr                         699|        691          -1.14%
Ir                    12,191,014| 12,142,116          -0.40%
L1hits                17,086,088| 17,013,083          -0.43%
LLhits                   196,449|    199,794          +1.70%
RamHits                   15,886|     13,954         -12.16%
TotalRW               17,298,423| 17,226,831          -0.41%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_2:load_from_name(procedural-string-lights)
Instructions: 2,597,196 (master) → 1,819,933 (HEAD) : $$\color{lime}-29.93\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                      30,975|     18,474         -40.36%
D1mw                       7,853|      7,509          -4.38%
DLmr                          14|         16         +14.29%
DLmw                       2,877|      1,607         -44.14%
Dr                       635,192|    429,454         -32.39%
Dw                       441,937|    309,415         -29.99%
EstimatedCycles        3,956,269|  2,753,826         -30.39%
I1mr                       4,928|      5,568         +12.99%
ILmr                         673|        671          -0.30%
Ir                     2,597,196|  1,819,933         -29.93%
L1hits                 3,630,569|  2,527,251         -30.39%
LLhits                    40,192|     29,257         -27.21%
RamHits                    3,564|      2,294         -35.63%
TotalRW                3,674,325|  2,558,802         -30.36%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_3:load_from_name(parametric-dunescape)
Instructions: 12,312,200 (master) → 12,278,184 (HEAD) : $$\color{lime}-0.28\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     160,258|    160,187          -0.04%
D1mw                      44,678|     44,686          +0.02%
DLmr                          79|         98         +24.05%
DLmw                      14,948|     15,026          +0.52%
Dr                     3,013,188|  3,004,674          -0.28%
Dw                     2,120,424|  2,114,633          -0.27%
EstimatedCycles       18,815,516| 18,779,475          -0.19%
I1mr                      18,810|     21,283         +13.15%
ILmr                         797|        788          -1.13%
Ir                    12,312,200| 12,278,184          -0.28%
L1hits                17,222,066| 17,171,335          -0.29%
LLhits                   207,922|    210,244          +1.12%
RamHits                   15,824|     15,912          +0.56%
TotalRW               17,445,812| 17,397,491          -0.28%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_4:load_from_name(red-dress)
Instructions: 27,604,726 (master) → 27,532,746 (HEAD) : $$\color{lime}-0.26\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     348,188|    345,284          -0.83%
D1mw                      92,969|     92,614          -0.38%
DLmr                      42,680|     41,883          -1.87%
DLmw                      61,158|     50,818         -16.91%
Dr                     6,823,965|  6,799,865          -0.35%
Dw                     4,752,861|  4,738,485          -0.30%
EstimatedCycles       44,295,884| 43,868,314          -0.97%
I1mr                      52,431|     59,909         +14.26%
ILmr                         828|        832          +0.48%
Ir                    27,604,726| 27,532,746          -0.26%
L1hits                38,687,964| 38,573,289          -0.30%
LLhits                   388,922|    404,274          +3.95%
RamHits                  104,666|     93,533         -10.64%
TotalRW               39,181,552| 39,071,096          -0.28%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_5:load_from_name(valley-of-spires)
Instructions: 17,597,782 (master) → 17,535,619 (HEAD) : $$\color{lime}-0.35\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     215,285|    215,309          +0.01%
D1mw                      54,844|     55,238          +0.72%
DLmr                      13,880|     13,270          -4.39%
DLmw                      29,617|     29,708          +0.31%
Dr                     4,372,155|  4,354,588          -0.40%
Dw                     3,036,399|  3,025,453          -0.36%
EstimatedCycles       27,556,798| 27,472,502          -0.31%
I1mr                      35,514|     40,471         +13.96%
ILmr                         766|        781          +1.96%
Ir                    17,597,782| 17,535,619          -0.35%
L1hits                24,700,693| 24,604,642          -0.39%
LLhits                   261,380|    267,259          +2.25%
RamHits                   44,263|     43,759          -1.14%
TotalRW               25,006,336| 24,915,660          -0.36%

🔄 Executor Update

update_executor_iai::update_group::update_executor with_setup_0:setup_update_executor(isometric-fountain)
Instructions: 41,136,306 (master) → 41,165,201 (HEAD) : $$\color{red}+0.07\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     454,001|    449,399          -1.01%
D1mw                      99,609|     97,872          -1.74%
DLmr                       8,450|      9,107          +7.78%
DLmw                      26,337|     31,515         +19.66%
Dr                    10,455,996| 10,464,119          +0.08%
Dw                     7,065,054|  7,084,375          +0.27%
EstimatedCycles       62,058,306| 62,262,251          +0.33%
I1mr                      33,730|     33,343          -1.15%
ILmr                         266|        248          -6.77%
Ir                    41,136,306| 41,165,201          +0.07%
L1hits                58,070,016| 58,133,081          +0.11%
LLhits                   552,287|    539,744          -2.27%
RamHits                   35,053|     40,870         +16.59%
TotalRW               58,657,356| 58,713,695          +0.10%

update_executor_iai::update_group::update_executor with_setup_1:setup_update_executor(painted-dreams)
Instructions: 22,778,785 (master) → 22,806,778 (HEAD) : $$\color{red}+0.12\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     235,480|    237,037          +0.66%
D1mw                      52,717|     52,383          -0.63%
DLmr                         929|        968          +4.20%
DLmw                      12,558|     12,486          -0.57%
Dr                     5,746,524|  5,751,379          +0.08%
Dw                     3,907,839|  3,908,431          +0.02%
EstimatedCycles       34,075,714| 34,117,026          +0.12%
I1mr                      19,777|     20,762          +4.98%
ILmr                         202|        203          +0.50%
Ir                    22,778,785| 22,806,778          +0.12%
L1hits                32,125,174| 32,156,406          +0.10%
LLhits                   294,285|    296,525          +0.76%
RamHits                   13,689|     13,657          -0.23%
TotalRW               32,433,148| 32,466,588          +0.10%

update_executor_iai::update_group::update_executor with_setup_2:setup_update_executor(procedural-string-lights)
Instructions: 4,776,592 (master) → 4,668,153 (HEAD) : $$\color{lime}-2.27\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                      46,745|     42,754          -8.54%
D1mw                      11,569|     10,808          -6.58%
DLmr                           2|          2          +0.00%
DLmw                         484|        332         -31.40%
Dr                     1,203,887|  1,156,350          -3.95%
Dw                       818,342|    778,933          -4.82%
EstimatedCycles        7,072,815|  6,854,440          -3.09%
I1mr                       5,032|      5,169          +2.72%
ILmr                         201|        202          +0.50%
Ir                     4,776,592|  4,668,153          -2.27%
L1hits                 6,735,475|  6,544,705          -2.83%
LLhits                    62,659|     58,195          -7.12%
RamHits                      687|        536         -21.98%
TotalRW                6,798,821|  6,603,436          -2.87%

update_executor_iai::update_group::update_executor with_setup_3:setup_update_executor(parametric-dunescape)
Instructions: 18,938,066 (master) → 18,978,972 (HEAD) : $$\color{red}+0.22\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     184,312|    186,374          +1.12%
D1mw                      46,161|     46,364          +0.44%
DLmr                         121|        111          -8.26%
DLmw                       7,401|      6,689          -9.62%
Dr                     4,732,187|  4,765,961          +0.71%
Dw                     3,246,999|  3,280,886          +1.04%
EstimatedCycles       28,132,928| 28,227,957          +0.34%
I1mr                      15,681|     15,394          -1.83%
ILmr                         180|        187          +3.89%
Ir                    18,938,066| 18,978,972          +0.22%
L1hits                26,671,098| 26,777,687          +0.40%
LLhits                   238,452|    241,145          +1.13%
RamHits                    7,702|      6,987          -9.28%
TotalRW               26,917,252| 27,025,819          +0.40%

update_executor_iai::update_group::update_executor with_setup_4:setup_update_executor(red-dress)
Instructions: 51,152,879 (master) → 51,225,018 (HEAD) : $$\color{red}+0.14\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     547,249|    553,881          +1.21%
D1mw                     128,399|    124,749          -2.84%
DLmr                      18,682|     17,351          -7.12%
DLmw                      42,982|     46,411          +7.98%
Dr                    13,135,406| 13,151,548          +0.12%
Dw                     9,005,609|  9,020,313          +0.16%
EstimatedCycles       78,009,600| 78,187,181          +0.23%
I1mr                      38,211|     38,608          +1.04%
ILmr                         345|        283         -17.97%
Ir                    51,152,879| 51,225,018          +0.14%
L1hits                72,580,035| 72,679,641          +0.14%
LLhits                   651,850|    653,193          +0.21%
RamHits                   62,009|     64,045          +3.28%
TotalRW               73,293,894| 73,396,879          +0.14%

update_executor_iai::update_group::update_executor with_setup_5:setup_update_executor(valley-of-spires)
Instructions: 32,771,441 (master) → 32,764,034 (HEAD) : $$\color{lime}-0.02\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     363,207|    360,232          -0.82%
D1mw                      80,428|     78,194          -2.78%
DLmr                       3,969|      3,891          -1.97%
DLmw                      23,293|     25,551          +9.69%
Dr                     8,336,675|  8,334,686          -0.02%
Dw                     5,660,945|  5,660,968          +0.00%
EstimatedCycles       49,471,567| 49,509,020          +0.08%
I1mr                      25,869|     26,532          +2.56%
ILmr                         221|        208          -5.88%
Ir                    32,771,441| 32,764,034          -0.02%
L1hits                46,299,557| 46,294,730          -0.01%
LLhits                   442,021|    435,308          -1.52%
RamHits                   27,483|     29,650          +7.88%
TotalRW               46,769,061| 46,759,688          -0.02%

🚀 Render: Cold Execution

run_once_iai::run_once_group::run_once with_setup_0:setup_run_once(isometric-fountain)
Instructions: 20,688,072 (master) → 20,717,636 (HEAD) : $$\color{red}+0.14\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     236,075|    237,446          +0.58%
D1mw                      49,895|     49,675          -0.44%
DLmr                      11,330|     12,036          +6.23%
DLmw                      15,589|     15,840          +1.61%
Dr                     5,257,558|  5,286,726          +0.55%
Dw                     3,511,178|  3,538,175          +0.77%
EstimatedCycles       32,008,784| 32,116,841          +0.34%
I1mr                     114,004|    111,595          -2.11%
ILmr                       4,817|      4,772          -0.93%
Ir                    20,688,072| 20,717,636          +0.14%
L1hits                29,056,834| 29,143,821          +0.30%
LLhits                   368,238|    366,068          -0.59%
RamHits                   31,736|     32,648          +2.87%
TotalRW               29,456,808| 29,542,537          +0.29%

run_once_iai::run_once_group::run_once with_setup_1:setup_run_once(painted-dreams)
Instructions: 76,779,050 (master) → 76,737,289 (HEAD) : $$\color{lime}-0.05\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     386,625|    385,269          -0.35%
D1mw                     180,461|    180,762          +0.17%
DLmr                       5,066|      5,288          +4.38%
DLmw                      47,582|     49,433          +3.89%
Dr                    18,158,486| 18,166,422          +0.04%
Dw                    12,176,414| 12,189,402          +0.11%
EstimatedCycles      111,839,008|111,820,653          -0.02%
I1mr                     166,466|    152,849          -8.18%
ILmr                       7,047|      7,013          -0.48%
Ir                    76,779,050| 76,737,289          -0.05%
L1hits               106,380,398|106,374,233          -0.01%
LLhits                   673,857|    657,146          -2.48%
RamHits                   59,695|     61,734          +3.42%
TotalRW              107,113,950|107,093,113          -0.02%

run_once_iai::run_once_group::run_once with_setup_2:setup_run_once(procedural-string-lights)
Instructions: 9,726,222 (master) → 9,585,019 (HEAD) : $$\color{lime}-1.45\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                      43,488|     37,973         -12.68%
D1mw                      16,556|     16,549          -0.04%
DLmr                         262|        298         +13.74%
DLmw                       3,467|      3,978         +14.74%
Dr                     2,228,245|  2,194,494          -1.51%
Dw                     1,542,718|  1,524,818          -1.16%
EstimatedCycles       14,110,049| 13,905,955          -1.45%
I1mr                      34,327|     33,364          -2.81%
ILmr                       4,117|      4,060          -1.38%
Ir                     9,726,222|  9,585,019          -1.45%
L1hits                13,402,814| 13,216,445          -1.39%
LLhits                    86,525|     79,550          -8.06%
RamHits                    7,846|      8,336          +6.25%
TotalRW               13,497,185| 13,304,331          -1.43%

run_once_iai::run_once_group::run_once with_setup_3:setup_run_once(parametric-dunescape)
Instructions: 26,270,326 (master) → 26,284,804 (HEAD) : $$\color{red}+0.06\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     120,474|    120,050          -0.35%
D1mw                      50,211|     49,621          -1.18%
DLmr                       1,578|      1,548          -1.90%
DLmw                      10,262|     10,450          +1.83%
Dr                     5,832,748|  5,855,712          +0.39%
Dw                     3,463,370|  3,488,436          +0.72%
EstimatedCycles       36,952,080| 37,008,068          +0.15%
I1mr                      61,934|     60,598          -2.16%
ILmr                       3,332|      3,270          -1.86%
Ir                    26,270,326| 26,284,804          +0.06%
L1hits                35,333,825| 35,398,683          +0.18%
LLhits                   217,447|    215,001          -1.12%
RamHits                   15,172|     15,268          +0.63%
TotalRW               35,566,444| 35,628,952          +0.18%

run_once_iai::run_once_group::run_once with_setup_4:setup_run_once(red-dress)
Instructions: 1,884,309,524 (master) → 1,884,656,177 (HEAD) : $$\color{red}+0.02\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                   1,535,234|  1,521,292          -0.91%
D1mw                     700,326|    693,284          -1.01%
DLmr                     325,755|    317,126          -2.65%
DLmw                     444,027|    446,967          +0.66%
Dr                   437,099,795|437,299,265          +0.05%
Dw                   278,934,587|279,062,531          +0.05%
EstimatedCycles      2,635,822,292|2,635,669,473          -0.01%
I1mr                     822,549|    678,714         -17.49%
ILmr                       5,083|      5,185          +2.01%
Ir                   1,884,309,524|1,884,656,177          +0.02%
L1hits               2,597,285,797|2,598,124,683          +0.03%
LLhits                 2,283,244|  2,124,012          -6.97%
RamHits                  774,865|    769,278          -0.72%
TotalRW              2,600,343,906|2,601,017,973          +0.03%

run_once_iai::run_once_group::run_once with_setup_5:setup_run_once(valley-of-spires)
Instructions: 19,103,007 (master) → 19,053,454 (HEAD) : $$\color{lime}-0.26\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     193,132|    191,360          -0.92%
D1mw                      44,031|     43,493          -1.22%
DLmr                       5,696|      5,613          -1.46%
DLmw                      12,563|     11,863          -5.57%
Dr                     4,652,570|  4,633,253          -0.42%
Dw                     3,080,206|  3,065,545          -0.48%
EstimatedCycles       28,796,975| 28,668,186          -0.45%
I1mr                      93,085|     90,373          -2.91%
ILmr                       3,081|      3,025          -1.82%
Ir                    19,103,007| 19,053,454          -0.26%
L1hits                26,505,535| 26,427,026          -0.30%
LLhits                   308,908|    304,725          -1.35%
RamHits                   21,340|     20,501          -3.93%
TotalRW               26,835,783| 26,752,252          -0.31%

⚡ Render: Cached Execution

run_cached_iai::run_cached_group::run_cached with_setup_0:setup_run_cached(isometric-fountain)
Instructions: 20,809,859 (master) → 20,848,177 (HEAD) : $$\color{red}+0.18\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     251,599|    253,672          +0.82%
D1mw                      44,193|     45,031          +1.90%
DLmr                       4,246|      4,005          -5.68%
DLmw                         615|        636          +3.41%
Dr                     5,335,685|  5,371,974          +0.68%
Dw                     3,513,605|  3,553,579          +1.14%
EstimatedCycles       31,450,947| 31,554,700          +0.33%
I1mr                     114,485|    110,487          -3.49%
ILmr                         162|        166          +2.47%
Ir                    20,809,859| 20,848,177          +0.18%
L1hits                29,248,872| 29,364,540          +0.40%
LLhits                   405,254|    404,383          -0.21%
RamHits                    5,023|      4,807          -4.30%
TotalRW               29,659,149| 29,773,730          +0.39%

run_cached_iai::run_cached_group::run_cached with_setup_1:setup_run_cached(painted-dreams)
Instructions: 26,351,252 (master) → 26,349,205 (HEAD) : $$\color{lime}-0.01\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     220,461|    219,611          -0.39%
D1mw                      54,460|     54,069          -0.72%
DLmr                       1,407|      2,107         +49.75%
DLmw                       2,044|      1,180         -42.27%
Dr                     6,489,955|  6,482,213          -0.12%
Dw                     4,427,472|  4,420,614          -0.15%
EstimatedCycles       38,787,825| 38,720,612          -0.17%
I1mr                      77,843|     67,620         -13.13%
ILmr                         152|        159          +4.61%
Ir                    26,351,252| 26,349,205          -0.01%
L1hits                36,915,915| 36,910,732          -0.01%
LLhits                   349,161|    337,854          -3.24%
RamHits                    3,603|      3,446          -4.36%
TotalRW               37,268,679| 37,252,032          -0.04%

run_cached_iai::run_cached_group::run_cached with_setup_2:setup_run_cached(procedural-string-lights)
Instructions: 9,253,346 (master) → 9,008,630 (HEAD) : $$\color{lime}-2.64\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                      51,460|     43,604         -15.27%
D1mw                      14,259|     13,803          -3.20%
DLmr                           7|          7          +0.00%
DLmw                         104|        153         +47.12%
Dr                     2,143,105|  2,067,280          -3.54%
Dw                     1,484,464|  1,431,424          -3.57%
EstimatedCycles       13,283,761| 12,866,692          -3.14%
I1mr                      33,005|     30,055          -8.94%
ILmr                         154|        157          +1.95%
Ir                     9,253,346|  9,008,630          -2.64%
L1hits                12,782,191| 12,419,872          -2.83%
LLhits                    98,459|     87,145         -11.49%
RamHits                      265|        317         +19.62%
TotalRW               12,880,915| 12,507,334          -2.90%

run_cached_iai::run_cached_group::run_cached with_setup_3:setup_run_cached(parametric-dunescape)
Instructions: 16,181,735 (master) → 16,215,944 (HEAD) : $$\color{red}+0.21\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     104,698|    105,711          +0.97%
D1mw                      34,903|     36,139          +3.54%
DLmr                          40|         35         -12.50%
DLmw                         516|      1,296        +151.16%
Dr                     3,658,373|  3,692,631          +0.94%
Dw                     2,421,124|  2,456,056          +1.44%
EstimatedCycles       22,943,464| 23,074,427          +0.57%
I1mr                      25,947|     24,739          -4.66%
ILmr                         112|        117          +4.46%
Ir                    16,181,735| 16,215,944          +0.21%
L1hits                22,095,684| 22,198,042          +0.46%
LLhits                   164,880|    165,141          +0.16%
RamHits                      668|      1,448        +116.77%
TotalRW               22,261,232| 22,364,631          +0.46%

run_cached_iai::run_cached_group::run_cached with_setup_4:setup_run_cached(red-dress)
Instructions: 280,141,202 (master) → 280,295,582 (HEAD) : $$\color{red}+0.06\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                   1,427,879|  1,431,069          +0.22%
D1mw                     461,514|    462,349          +0.18%
DLmr                     487,903|    493,108          +1.07%
DLmw                     227,766|    223,401          -1.92%
Dr                    68,155,168| 68,228,790          +0.11%
Dw                    48,976,427| 48,979,258          +0.01%
EstimatedCycles      429,609,047|429,031,364          -0.13%
I1mr                     796,642|    584,908         -26.58%
ILmr                       4,068|      3,972          -2.36%
Ir                   280,141,202|280,295,582          +0.06%
L1hits               394,586,762|395,025,304          +0.11%
LLhits                 1,966,298|  1,757,845         -10.60%
RamHits                  719,737|    720,481          +0.10%
TotalRW              397,272,797|397,503,630          +0.06%

run_cached_iai::run_cached_group::run_cached with_setup_5:setup_run_cached(valley-of-spires)
Instructions: 19,415,286 (master) → 19,399,989 (HEAD) : $$\color{lime}-0.08\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     207,300|    206,220          -0.52%
D1mw                      39,889|     39,646          -0.61%
DLmr                         386|        312         -19.17%
DLmw                         657|      1,164         +77.17%
Dr                     4,784,987|  4,781,420          -0.07%
Dw                     3,134,137|  3,132,118          -0.06%
EstimatedCycles       28,745,594| 28,715,401          -0.11%
I1mr                      96,667|     92,445          -4.37%
ILmr                         149|        145          -2.68%
Ir                    19,415,286| 19,399,989          -0.08%
L1hits                26,990,554| 26,975,216          -0.06%
LLhits                   342,664|    336,690          -1.74%
RamHits                    1,192|      1,621         +35.99%
TotalRW               27,334,410| 27,313,527          -0.08%

Self::Error("no source")
}
}
// /// Represents the result of a type query for an input or output connector.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be deleted?

@@ -6590,49 +6659,6 @@ struct InputTransientMetadata {
// types: populated for each protonode after each
}

// TODO: Eventually remove this migration document upgrade code
fn migrate_output_names<'de, D: serde::Deserializer<'de>>(deserializer: D) -> Result<Vec<String>, D::Error> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this moved elsewhere (that I can't find) or has it been fully removed? Unless its purpose has been obviated, we do still need these migrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants