Generate VOL tests for h5dump #5763
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
added
Component - Tools
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| @@ -951,7 +875,7 @@ macro (ADD_H5_TEST_IMPORT conffile resultfile testfile resultcode) | |||
| if ("H5DUMP-IMPORT-h5import-${resultfile}" MATCHES "${HDF5_DISABLE_TESTS_REGEX}") | |||
| set_tests_properties (H5DUMP-IMPORT-h5import-${resultfile} PROPERTIES DISABLED true) | |||
| endif () | |||
| add_test (NAME H5DUMP-IMPORT-h5diff-${resultfile} COMMAND ${CMAKE_CROSSCOMPILING_EMULATOR} $<TARGET_FILE:h5diff> ${testfile} ${resultfile}.h5 /integer /integer) | |||
| add_test (NAME H5DUMP-IMPORT- -${resultfile} COMMAND ${CMAKE_CROSSCOMPILING_EMULATOR} $<TARGET_FILE:h5diff> ${testfile} ${resultfile}.h5 /integer /integer) | |||
There was a problem hiding this comment.
There's a typographical error in the test name. The string 'H5DUMP-IMPORT- -${resultfile}' seems incorrect; it likely should be 'H5DUMP-IMPORT-h5diff-${resultfile}'.
Suggested change
| add_test (NAME H5DUMP-IMPORT- -${resultfile} COMMAND ${CMAKE_CROSSCOMPILING_EMULATOR} $<TARGET_FILE:h5diff> ${testfile} ${resultfile}.h5 /integer /integer) | |
| add_test (NAME H5DUMP-IMPORT-h5diff-${resultfile} COMMAND ${CMAKE_CROSSCOMPILING_EMULATOR} $<TARGET_FILE:h5diff> ${testfile} ${resultfile}.h5 /integer /integer) |
|
|
||
| # all | ||
| ADD_H5_COMP_TEST (tallfilters 0 1 --enable-error-stack -H -p -d all tfilters.h5) | ||
| if (H5_HAVE_FILTER_SZIP) | ||
| ADD_H5_TEST (tallfilters RESULT_CODE 0 APPLY_FILTERS 1 --enable-error-stack -H -p -d all TARGET_FILE tfilters.h5 APPLY_FILTERS 1) |
There was a problem hiding this comment.
Possible duplicate: The "APPLY_FILTERS 1" argument appears twice in the tallfilters test. Please confirm if the duplicate is intentional.
Suggested change
| ADD_H5_TEST (tallfilters RESULT_CODE 0 APPLY_FILTERS 1 --enable-error-stack -H -p -d all TARGET_FILE tfilters.h5 APPLY_FILTERS 1) | |
| ADD_H5_TEST (tallfilters RESULT_CODE 0 APPLY_FILTERS 1 --enable-error-stack -H -p -d all TARGET_FILE tfilters.h5) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5761 and #5752. Will be marked ready for review once those are merged
Important
Add VOL tests for h5dump, updating test generation and execution to support VOL connectors and specific configurations.
H5DUMPtests fromctestin.github/workflows/vol_rest.yml.CMakeTests.cmake.ADD_H5_TESTmacro inCMakeTests.cmaketo support VOL connectors, including handling of environment variables and test dependencies.gent_tvms()inh5dumpgentest.candh5dumpgentest.hfor generating VMS test files.write_dset()inh5dumpgentest.cto accept separate dataset and memory types._Float16tests inCMakeTestsXML.cmake.h5gentest.cfortCVE-2021-37501_attr_decodetest name.This description was created by
for 98124ec. You can customize this summary. It will automatically update as commits are pushed.