-
Notifications
You must be signed in to change notification settings - Fork 273
Fix handling of checkbox inputs and optional arrays in UI #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+44,182
β3,578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
β¦cation and SSO (#862) * Multitenancy support Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Cleanup comments and duplicate env Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Cleanup comments and duplicate env Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix smoketest Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix docker-compose Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix postgres Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * .env.example update Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * flake8 alembic script Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Update helm charts Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Update docs Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Update docstring Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Update docstring Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Update docstring Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Update ruff Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Update docs Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Update doctest Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Update doctest 45% Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix blocking removal of last admin Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix blocking removal of last admin Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix number of team members Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix team approval workflow Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix logs Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix logs Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Add multitenancy scripts to check migration Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Add multitenancy scripts to check migration Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Add manual testing Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Add manual testing Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Add manual testing Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix gateways a2a and prompts migration Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix APP_ROOT_PATH Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix APP_ROOT_PATH part 2 Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * flake8 Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Update names in UI Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Update Tools samples for Bulk Import Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Update docs for password change Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Add 2nd pass. check field Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Add 2nd pass. check field Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix missing token_usage_logs migration Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix missing token_usage_logs migration Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix JSON types during migration Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix JSON types during migration Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Major refactor migration Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Major refactor migration Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix flake8 Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix import Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix import Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix import Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix import Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Fix tests Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>
Likely fixed in latest, please re-open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Bug-fix PR
π Summary
Form field generation for array types was incomplete and inconsistent:
"false"
).key
while others usedkey[]
.anyOf: [ { type:"array" }, { type:"null" } ]
(nullable arrays) were not recognized as arrays, causing the UI to render incorrectly and hide the Add items button.π Reproduction Steps
items.type = boolean
(boolean array).anyOf: [ { type:"array", items:{...} }, { type:"null" } ]
(nullable array)."false"
.π Root Cause
<input type="checkbox">
was rendered for booleans β unchecked state omitted.key
vskey[]
).prop.type === "array"
only, soanyOf
/oneOf
unions withnull
were missed.π‘ Fix Description
<input type="hidden" value="false">
for every boolean array item."false"
is submitted when unchecked.keyValidation.value + "[]"
.number
,boolean
,text
) instead of mutating a single element.anyOf
/oneOf
alongsidenull
.anyOf: [ {type:"array"}, {type:"null"} ]
.null
.π§ͺ Verification
make lint
make test
"false"
anyOf: [array, null]
renders with Add items button and submits properlyπ MCP Compliance (if relevant)
β Checklist
make black isort pre-commit
)