Skip to content

Pkg.Registry.update(): add throw_on_error kwarg #4245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Pkg.Registry.update(): add throw_on_error kwarg #4245

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fec9002
`Pkg.Registry.update()`: throw if an error is encountered
DilumAluthge May 22, 2025
e003a4b
Fix some more locations
DilumAluthge May 22, 2025
d430c1a
Set `throw_on_error = false` by default
DilumAluthge May 23, 2025
918f84b
Wait until the end to throw
DilumAluthge May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Registry/Registry.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ function update(; name=nothing, uuid=nothing, url=nothing, path=nothing, linked=
update([RegistrySpec(; name, uuid, url, path, linked)]; kwargs...)
end
end
function update(regs::Vector{RegistrySpec}; io::IO=stderr_f(), force::Bool=true, depots = [depots1()], update_cooldown = Second(1))
function update(regs::Vector{RegistrySpec}; io::IO=stderr_f(), force::Bool=true, depots = [depots1()], update_cooldown = Second(1), throw_on_error = false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe could be:

Suggested change
function update(regs::Vector{RegistrySpec}; io::IO=stderr_f(), force::Bool=true, depots = [depots1()], update_cooldown = Second(1), throw_on_error = false)
function update(regs::Vector{RegistrySpec}; io::IO=stderr_f(), force::Bool=true, depots = [depots1()], update_cooldown = Second(1), strict::Bool=false)

We already have a Pkg.precompile(; strict::Bool=false) which reminds me of this

registry_update_log = get_registry_update_log()
for depot in depots
depot_regs = isempty(regs) ? reachable_registries(; depots=depot) : regs
Expand Down Expand Up @@ -554,6 +554,9 @@ function update(regs::Vector{RegistrySpec}; io::IO=stderr_f(), force::Bool=true,
warn_str *= "\n — $reg — $err"
end
@error warn_str
if throw_on_error
Pkg.Types.pkgerror(warn_str)
end
Comment on lines 556 to +559
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to both have an @error and an exception?

end
end # mkpidlock
end
Expand Down