Skip to content

Fix completion at the end of a complete line #4373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

IanButterworth
Copy link
Member

Fixes JuliaLang/julia#58690
Fixes JuliaLang/julia#58103

Using Claude.

test/repl.jl Outdated
Comment on lines 846 to 847
using REPL
import REPL.LineEdit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repl.jl: Error During Test at /Users/runner/work/Pkg.jl/Pkg.jl/test/runtests.jl:83
  Got exception outside of a @test
  LoadError: syntax: "using" expression not at top level
  Stacktrace:
    [1] top-level scope
      @ ~/work/Pkg.jl/Pkg.jl/test/repl.jl:840
    [2] include(mapexpr::Function, mod::Module, _path::String)
      @ Base ./Base.jl:309
    [3] IncludeInto
      @ ./Base.jl:310 [inlined]
    [4] macro expansion
      @ ~/work/Pkg.jl/Pkg.jl/test/runtests.jl:86 [inlined]
    [5] macro expansion
      @ ~/hostedtoolcache/julia/nightly/aarch64/share/julia/stdlib/v1.13/Test/src/Test.jl:2019 [inlined]
    [6] macro expansion
      @ ~/work/Pkg.jl/Pkg.jl/test/runtests.jl:83 [inlined]
    [7] macro expansion
      @ ~/hostedtoolcache/julia/nightly/aarch64/share/julia/stdlib/v1.13/Test/src/Test.jl:1930 [inlined]
    [8] (::Main.PkgTestsOuter.PkgTestsInner.var"#2#3")()
      @ Main.PkgTestsOuter.PkgTestsInner ~/work/Pkg.jl/Pkg.jl/test/runtests.jl:81
    [9] with_logstate(f::Main.PkgTestsOuter.PkgTestsInner.var"#2#3", logstate::Base.CoreLogging.LogState)
      @ Base.CoreLogging ./logging/logging.jl:540
   [10] with_logger(f::Function, logger::Base.CoreLogging.ConsoleLogger)
      @ Base.CoreLogging ./logging/logging.jl:651
   [11] top-level scope
      @ ~/work/Pkg.jl/Pkg.jl/test/runtests.jl:38
   [12] include(mapexpr::Function, mod::Module, _path::String)
      @ Base ./Base.jl:309
   [13] top-level scope
      @ none:6
   [14] eval(m::Module, e::Any)
      @ Core ./boot.jl:489
   [15] exec_options(opts::Base.JLOptions)
      @ Base ./client.jl:296
   [16] _start()
      @ Base ./client.jl:563
  in expression starting at /Users/runner/work/Pkg.jl/Pkg.jl/test/repl.jl:3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked it as draft as it's not ready for review. Just wanted to get this opened before I was AFK.

I've not reviewed the test code yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
2 participants