Updated devcontainer definition #59285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensuring:
* Running as non-root user to make tests pass, notably `Base.runtests("file")` - by basing container on mcr.microsoft.com/devcontainers/cpp.
* Availability of `gdb`.
* Caching when building/creating container by using build stages (and devcontainer features) instead of `onCreateCommand`.
Also added the Makefile Tools extension (and the C/C++ Extension Pack to quiet vscode/codespaces).
|
My understanding is that Dockerfiles were deprecated, that's why #57006 removed it. |
|
I did notice #57006 - is there any documentation for Dockerfile being deprecated for devcontainer definitions? I can't seem to find it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensuring:
Base.runtests("file")- by basing container onmcr.microsoft.com/devcontainers/cpp.gdb.onCreateCommand.Also added the Makefile Tools extension (and the C/C++ Extension Pack to quiet vscode/codespaces).