spawn: Allow libuv IOServers to be passed as extra FDs #59373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from #59271, but I now have an independent use case. This allows libuv `IOServer`s (unix domain servers, tcp servers, etc) to be passed as extra fd arguments to child processes.
Keno
force-pushed
the
kf/extraserverfds
branch
from
9762521 to
458934f
Compare
vtjnash
reviewed
Aug 25, 2025
| # Test passing a pipe server as an addition fd | ||
| @testset "Pipe server as additional fd" begin | ||
| if !Sys.iswindows() | ||
| # Windows CRT does not support passing server sockets as stdio fds |
There was a problem hiding this comment.
I assume it is officially disallowed, but does it do any verification, or would the test pass if attempted? Since passing sockets at all is also officially documented as broken in the NT kernel due to various ancient design and implementation mistakes of long deprecated APIs around WSADuplicateSocket/DuplicateHandle, but it does mostly work (https://news.ycombinator.com/item?id=24969257)
There was a problem hiding this comment.
libuv checks and returns EOPNOTSUP. What would happen if you bypassed that, I do not know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #59271, but I now have an independent use case. This allows libuv
IOServers (unix domain servers, tcp servers, etc) to be passed as extra fd arguments to child processes.