fix(product): Correctly handle nested memory structure in chat methods #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary: This PR fixes an
AttributeError
that occurred in bothchat()
andchat_with_references()
when processing memory references for streaming responses. The root cause was an incorrect assumption about the data structure returned from the search method.Fix: #(no existing issue - bug found during development)
Docs Issue/PR: (not applicable)
Reviewer: @(leave blank)
Root Cause
The
super().search()
method returns a list of dictionaries, where each dictionary is structured as{"cube_id": "...", "memories": [TextualMemoryItem, ...]}
.The code was incorrectly trying to access attributes like
.id
and.model_dump()
on the outer dictionary instead of on theTextualMemoryItem
objects contained within the"memories"
key.Solution
A nested loop has been added to correctly iterate through the
TextualMemoryItem
objects. This ensures we are operating on the actual Pydantic models and can access their attributes without error.Checklist: