Use $proxy_add_x_forwarded_for for custom locations
#4348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use $proxy_add_x_forwarded_for when setting X-Forwarded-For in custom locations to match how it is set for default location
|
Docker Image for build 1 is available on Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
$proxy_add_x_forwarded_forwhen settingX-Forwarded-Forin custom locations to match how it is set for default location.The proxy settings included in the default location uses
$proxy_add_x_forwarded_forinstead of$remote_addrsince 052cb8f, which handles when NPM is behind multiple reverse proxies.This commit makes sure the same setting is used when creating custom location blocks for a proxy host.