Skip to content

Conversation

KristianAN
Copy link
Contributor

@KristianAN KristianAN commented Aug 27, 2025

The code for setting the form body parameters were wrong,

e.g. the key value pair (id, 12345) would be encoded as id=%28id%2C12345%29

This commit adds a fix to the base client to correctly setting formBody values the previous pair will now be encoded as

id=12345

@clasnake (2017/07), @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04) @Fish86 (2023/06)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

The code for setting the form body parameters were wrong,

e.g. the key value pair (id, 12345) would be encoded as
id=%28id%2C12345%29

This commit adds a fix to the base client to correctly setting formBody values the previous pair will now be encoded as

id=12345
@KristianAN KristianAN changed the title Update baseClient.mustache for scala-http4s [BUGFIX] scala-http4s fix bad encoding of form-urlencoded body in baseClient.mustache Aug 27, 2025
@wing328
Copy link
Member

wing328 commented Aug 28, 2025

thanks for the PR

did you test this fix in your environment to confirm it addresses the issue mentioned?

@KristianAN
Copy link
Contributor Author

KristianAN commented Aug 28, 2025

Yes, I have tested this in a generated client

@wing328 wing328 merged commit bd0b81d into OpenAPITools:master Aug 29, 2025
26 checks passed
@wing328 wing328 added this to the 7.16.0 milestone Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants