Implementing SVE in [SD]AXPY Kernels for A64FX and Graviton3E
#5426
+93
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snadampal
reviewed
Aug 21, 2025
| @@ -32,6 +32,10 @@ SGEMVNKERNEL = gemv_n_sve_v1x3.c | |||
| DGEMVNKERNEL = gemv_n_sve_v1x3.c | |||
| SGEMVTKERNEL = gemv_t_sve_v1x3.c | |||
| DGEMVTKERNEL = gemv_t_sve_v1x3.c | |||
|
|
|||
| SAXPYKERNEL = axpy_sve.c | |||
| DAXPYKERNEL = axpy_sve.c | |||
There was a problem hiding this comment.
since you have used the SVL for the implementation instead of hardcoding the vector width, the kernel should work on NEOVERSEV2 as well. Please check this on Graviton4 and add it to KERNEL.NEOVERSEV2 as well.
snadampal
reviewed
Aug 21, 2025
| BLASLONG sve_size = SV_COUNT(); | ||
|
|
||
| if (n < 0) return (0); | ||
| if (da == 0.0) return (0); |
There was a problem hiding this comment.
why can't these two checks be combined into one?
There was a problem hiding this comment.
Thank you for your comments.
There was another way you mentioned, but I followed kernel/arm/axpy.c#L45-L46.
|
Hi @hideaki-motoki , thanks for the PR! I have added few comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5417.
This change improves the performance of
[SD]AXPYon bothA64FXandGraviton3E.The graphs below show the single thread performance improvement of
[D]AXPYonA64FXandGraviton3E, respectively.The performance improved by 2.57 times on the
A64FXand 1.13 times on theGraviton3E.I have confirmed that this optimization also yields performance benefits for Level 2 BLAS kernels that utilize
[SD]AXPY, such as[SD]SPMVand[SD]GER.