You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A need to observe what is actually hidden in KEYS_TO_IGNORE and - what possible changes are making - the need araised - since it is quite dull to check 100 indexes by hand. Therefore I made script that does alike locally (thus still requires truckload of copy-pasting) - then I thought it could be useful to set it online.
PR as draft, to review idea and ... I am certain I made some mistake/oversight :)
Screenshot to give idea (made with staged files in staged repository for testing, its just showcase)
For details click the build job and expand Run checkson the CI logs.
MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)
Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)
SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
Other translations
MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)
Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)
SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
@tupaschoal Hi!
Could you say what do you think about this idea?
Is it worth pursuing and completing - including auto-expanded diffs for suppress_warning.py, or is this an excessive and overkill?
I could complete it with ease, but I would really like to hear if it is good, or should I let it go?
Thanks in advance :)
I'm not sure I get all the ideas you're trying do here, would you mind explaining it in another way?
@tupaschoal yes - i see that my style of writing PR texts is terrible (i re-read it after myself after two weeks and found i tend to divert from actual topic in writing ... which i am doing once again... facepalm)
The idea is to create an Action () script that would:
get activated only in case when PR in this repository proposes modification to translation_check.py (or suppress_warning.py)
produce output into comment under such PR
comment would contain diff-like summary of what is being done
the envisioned usefulness of such action is expanding STR_nnnn variables to their full 'meaning' - so the human person reviewing the PR doesn't have to do any extra look-up
the secondary envisioned usefulness is to mark STR numbers that are no more present in en-GB.txt, hence the maintainers and reviewers can take according actions
I see, thanks for explaining @tygrysek90 . For the removal of strings I don't think it is very important, as we often do it ourselves and if we're searching and removing, it should find on the python script too.
As for helping with the lookup, it might be a good time saver. I'll let @Gymnasiast weigh in
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-comment PR-s touching scripts with explained diff showing changes to KEYS_TO_IGNORE in translation_check.py
Since I found myself helping @tupaschoal with summer cleaning :) of this repository in
A need to observe what is actually hidden in KEYS_TO_IGNORE and - what possible changes are making - the need araised - since it is quite dull to check 100 indexes by hand. Therefore I made script that does alike locally (thus still requires truckload of copy-pasting) - then I thought it could be useful to set it online.
PR as draft, to review idea and ... I am certain I made some mistake/oversight :)
Screenshot to give idea (made with staged files in staged repository for testing, its just showcase)