Skip to content

refactor: improve YAxisRenderer.renderAxisLabels #5194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: improve YAxisRenderer.renderAxisLabels #5194

wants to merge 1 commit into from

Conversation

t49tran
Copy link

@t49tran t49tran commented Sep 20, 2021

PR Checklist:

  • I have tested this extensively and it does not break any existing behavior.
  • I have added/updated examples and tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

Small refactor to YAxisRenderer by replacing the nested if / else with two functions to calculate the label position x and label text alignment.

Hopefully, this is helpful and improve readability a little bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@t49tran