Skip to content

Fix offsets not adjusted on autoscale #5251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix offsets not adjusted on autoscale #5251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions MPChartLib/src/main/java/com/github/mikephil/charting/charts/BarLineChartBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,12 @@ protected void onDraw(Canvas canvas) {
if (mXAxis.isEnabled())
mXAxisRenderer.computeAxis(mXAxis.mAxisMinimum, mXAxis.mAxisMaximum, false);

// Y-axis labels could have changed in size affecting the offsets
if (mAutoScaleMinMaxEnabled) {
calculateOffsets();
mViewPortHandler.refresh(mViewPortHandler.getMatrixTouch(), this, false);
}

mXAxisRenderer.renderAxisLine(canvas);
mAxisRendererLeft.renderAxisLine(canvas);
mAxisRendererRight.renderAxisLine(canvas);
Expand Down Expand Up @@ -366,19 +372,7 @@ protected void autoScale() {

mData.calcMinMaxY(fromX, toX);

mXAxis.calculate(mData.getXMin(), mData.getXMax());

// calculate axis range (min / max) according to provided data

if (mAxisLeft.isEnabled())
mAxisLeft.calculate(mData.getYMin(AxisDependency.LEFT),
mData.getYMax(AxisDependency.LEFT));

if (mAxisRight.isEnabled())
mAxisRight.calculate(mData.getYMin(AxisDependency.RIGHT),
mData.getYMax(AxisDependency.RIGHT));

calculateOffsets();
calcMinMax();
}

@Override
Expand Down