Improve/optimize arbitrary weapon/warhead detonation code #1825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Starkku
commented
Aug 18, 2025
Starkku
commented
- Reuse a special BulletClass instance for these detonations instead of always creating a new one.
- Fix a bug that causes the detonation coords to snap to the logical target - this is not always desirable and should be handled separately where needed by making sure the detonation coords are same as target coords.
- Reuse BulletClass instance instead of always creating new one, where possible. - Fix a bug that causes the detonation coords to snap to the logical target - this is not always desirable and should be handled separately where needed.
Starkku
force-pushed
the
fix/detonate-improvements
branch
from
d603f41 to
e6bb86d
Compare
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Coronia
approved these changes
Aug 26, 2025
Coronia
added
Tested
⚙️T1
DeathFishAtEase
added a commit
to DeathFishAtEase/Phobos
that referenced
this pull request
Aug 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.