Skip to content

[BlueskyBridge] prevent 408 request timeout by implementing cache #4666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[BlueskyBridge] prevent 408 request timeout by implementing cache #4666

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80092be
fix http timeout
mruac Aug 9, 2025
c74a377
fix http timeout
mruac Aug 9, 2025
55aa383
Merge branch '20250810-bluesky-httpcache' of https://github.com/mruac…
mruac Aug 11, 2025
3a7a056
semantics
mruac Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions bridges/BlueskyBridge.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public function collectData()
$item['author'] = $this->fallbackAuthor($post['post']['author'], 'display');

$postAuthorDID = $post['post']['author']['did'];
$postAuthorHandle = $post['post']['author']['handle'] !== 'handle.invalid' ? '<i>@' . $post['post']['author']['handle'] . '</i> ' : '';
$postAuthorHandle = $post['post']['author']['handle'] !== 'handle.invalid' ? '<i>@' . $post['post']['author']['handle'] . '</i>' : '';
$postDisplayName = $post['post']['author']['displayName'] ?? '';
$postDisplayName = e($postDisplayName);
$postUri = $item['uri'];
Expand Down Expand Up @@ -340,7 +340,7 @@ public function collectData()
} else {
$replyPostRecord = $replyPost['record'];
$replyPostAuthorDID = $replyPost['author']['did'];
$replyPostAuthorHandle = $replyPost['author']['handle'] !== 'handle.invalid' ? '<i>@' . $replyPost['author']['handle'] . '</i> ' : '';
$replyPostAuthorHandle = $replyPost['author']['handle'] !== 'handle.invalid' ? '<i>@' . $replyPost['author']['handle'] . '</i>' : '';
$replyPostDisplayName = $replyPost['author']['displayName'] ?? '';
$replyPostDisplayName = e($replyPostDisplayName);
$replyPostUri = self::URI . '/profile/' . $this->fallbackAuthor($replyPost['author'], 'url') . '/post/' . explode('app.bsky.feed.post/', $replyPost['uri'])[1];
Expand Down Expand Up @@ -528,8 +528,9 @@ private function getPostDescription(
$postType = isset($postRecord['reply']) ? 'reply' : 'post';
$description .= "Replying to <b>$postDisplayName</b> $postAuthorHandle's <a href=\"$postUri\">$postType</a>:<br>";
} else {
// aaa @aaa.com posted:
$description .= "<b>$postDisplayName</b> $postAuthorHandle <a href=\"$postUri\">posted</a>:<br>";
// aaa @aaa.com posted/replied:
$postType = isset($postRecord['reply']) ? 'replied' : 'posted';
$description .= "<b>$postDisplayName</b> $postAuthorHandle <a href=\"$postUri\">$postType</a>:<br>";
}
$description .= $this->textToDescription($postRecord);
return $description;
Expand All @@ -555,9 +556,19 @@ private function generateVerboseTitle($post)
//use "Post by A, replying to B, quoting C" instead of post contents
$title = '';
if (isset($post['reason']) && str_contains($post['reason']['$type'], 'reasonRepost')) {
$title .= 'Repost by ' . $this->fallbackAuthor($post['reason']['by'], 'display') . ', post by ' . $this->fallbackAuthor($post['post']['author'], 'display');
$title .= 'Repost by ' . $this->fallbackAuthor($post['reason']['by'], 'display');
if (isset($post['reply'])) {
$title .= ', reply by ';
} else {
$title .= ', post by ';
}
$title .= $this->fallbackAuthor($post['post']['author'], 'display');
} else {
$title .= 'Post by ' . $this->fallbackAuthor($post['post']['author'], 'display');
if (isset($post['reply'])) {
$title .= 'Reply by ' . $this->fallbackAuthor($post['post']['author'], 'display');
} else {
$title .= 'Post by ' . $this->fallbackAuthor($post['post']['author'], 'display');
}
}

if (isset($post['reply'])) {
Expand Down Expand Up @@ -595,15 +606,21 @@ private function generateVerboseTitle($post)

private function resolveHandle($handle)
{
$uri = 'https://public.api.bsky.app/xrpc/com.atproto.identity.resolveHandle?handle=' . urlencode($handle);
$response = json_decode(getContents($uri), true);
$url = 'https://public.api.bsky.app/xrpc/com.atproto.identity.resolveHandle?handle=' . urlencode($handle);
$response = $this->loadCacheValue($url) ?? json_decode(getContents($url), true);
if (isset($response['did'])) {
$this->saveCacheValue($url, $response, 604800);
}
return $response['did'];
}

private function getProfile($did)
{
$uri = 'https://public.api.bsky.app/xrpc/app.bsky.actor.getProfile?actor=' . urlencode($did);
$response = json_decode(getContents($uri), true);
$url = 'https://public.api.bsky.app/xrpc/app.bsky.actor.getProfile?actor=' . urlencode($did);
$response = $this->loadCacheValue($url) ?? json_decode(getContents($url), true);
if ($response['did'] === $did ?? false) {
$this->saveCacheValue($url, $response);
}
return $response;
}

Expand Down