fix(ui5-tabcontainer): Improve drag-and-drop to handle fast keyboard moves #12183
+64
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stoev
reviewed
Aug 25, 2025
There was a problem hiding this comment.
Please consider:
fix(ui5-tabcontainer): Improve drag-and-drop to handle fast keyboard moves
If of any additional value, please consider as well:
- The TabContainer implementation now uses a
_draggingflag to block concurrent tab moves while a drag is in progress.
TeodorTaushanov
changed the title
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TabContainer implementation now uses a _dragging flag to block concurrent tab moves while a drag is in progress.
fixes #11345