Skip to content

Conversation

NHristov-sap
Copy link
Contributor

@NHristov-sap NHristov-sap commented Aug 26, 2025

This PR adds and integrates new accessibility properties to the ui5-segmented-button component:

  • accessibleNameRef: Allows referencing external elements for the ARIA label.
  • accessibleDescription: Allows setting a custom accessible description.
  • accessibleDescriptionRef: Allows referencing external elements for the ARIA description.

ui5-segmented-button-item component also receives the following accessibility properties:

  • accessibleDescription: Allows setting a custom accessible description.
  • accessibleDescriptionRef: Allows referencing external elements for the ARIA description.

@NHristov-sap NHristov-sap requested a review from unazko August 27, 2025 09:07
Copy link
Contributor

@unazko unazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth mentioning that the ui5-segmented-button-item elements could also have descriptions. They're represented as li items as part of a ul element, which is the ui5-segmented-button.

@NHristov-sap
Copy link
Contributor Author

It's worth mentioning that the ui5-segmented-button-item elements could also have descriptions. They're represented as li items as part of a ul element, which is the ui5-segmented-button.

Added description functionality to ui5-segmented-button-item too.

@NHristov-sap NHristov-sap merged commit bf232e9 into main Aug 28, 2025
12 checks passed
@NHristov-sap NHristov-sap deleted the BL_segbtn_acc branch August 28, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants