make initial dt nothing #2838
Open
make initial dt nothing #2838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
force-pushed
the
os/improve-initial-dt-handling
branch
from
cf33b30 to
2994991
Compare
oscardssmith
commented
Aug 13, 2025
Comment on lines
-106
to
+107
| if prob.f.mass_matrix != I && (!(prob.f isa DynamicalODEFunction) || | ||
| any(mm != I for mm in prob.f.mass_matrix)) | ||
| if prob.f.mass_matrix !== I && (!(prob.f isa DynamicalODEFunction) || | ||
| any(mm !== I for mm in prob.f.mass_matrix)) |
|
Looks like convergence testing sets dt=0.0, along with some other things , so we need to still support that path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows for trimming of rosenbrock when initial_dt is set. Ideally, we would make init_dt selection fully trimmable also, but this is a start.