Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@zglicz zglicz changed the title Create rule S7658 Create rule S7658: Deprecated Node.js APIs should not be used Aug 20, 2025
@vdiez
Copy link
Contributor

vdiez commented Aug 21, 2025

I think this is a duplicate of S1874

@zglicz
Copy link
Contributor

zglicz commented Aug 21, 2025

Oh, their implementation actually doesn't rely on JSdoc on Typescript. They keep track of all deprecations: https://github.com/eslint-community/eslint-plugin-n/blob/master/lib/rules/no-deprecated-api.js

Should this be merged with the deprecation rule? Or, if the deprecation rule covers all of this, we just forget about this one?

@vdiez
Copy link
Contributor

vdiez commented Aug 21, 2025

I would just keep our rule and forget about this, even if typescript may be wrong because we will always rely on latest ts typings instead of the proper deprecations for each node.js version. wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants