Skip to content

Conversation

SHNakajima
Copy link
Contributor

@SHNakajima SHNakajima commented Jul 14, 2025

Closes #916

The root cause was that the .nav-buttons-container did not have a fixed minimum height, causing layout shifts when the loading animation started

Tested on:

  • Obsidian Mobile (Android Pixel 8): Jitter is resolved.
  • Obsidian Mobile (Android Emulator on Bluestack 720 x 1080 pixel): Jitter is resolved.
  • Obsidian Desktop: No regression observed.

@SHNakajima SHNakajima changed the title fix: Prevent jitter of refresh icon in mobile by setting min-height for nav-buttons-container fix: Prevent jitter of refresh icon in mobile Jul 14, 2025
@SHNakajima SHNakajima marked this pull request as ready for review July 14, 2025 14:33
@Vinzent03
Copy link
Owner

Vinzent03 commented Aug 23, 2025

I think using the variable --icon-size should be better. Could you test whether the that fixes the issue as well?

https://docs.obsidian.md/Reference/CSS+variables/Foundations/Icons

@SHNakajima
Copy link
Contributor Author

Thank you for checking on this!

I tried using the --icon-size variable as you suggested, but unfortunately it didn't resolve the issue.

However, I discovered that simply adding .loading { overflow: hidden; } to the original styles.css (before this PR's changes) actually fixes the problem completely. This seems like a much cleaner solution.

Let me know what you think about this approach!

@Vinzent03
Copy link
Owner

Okay great. Thanks for the fix!

@Vinzent03 Vinzent03 merged commit 180a314 into Vinzent03:master Aug 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Refresh Icon Jitter Issue in Git Source Control Toolbar
2 participants