Update JS-API for resizable buffer integration #1961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memory32 is the full 4GiB range. memory64 is at 2^37-1 so that when the page size is converted to bytes it is less than the JS MAX_SAFE_INTEGER value. Leave the runtime limits for memory sizes as-is.
We must allow maxsize greater than 4GiB for memory64. The impl limit for memory64 will ensure the maxsize is within MAX_SAFE_INTEGER.
tlively
reviewed
Aug 19, 2025
tlively
reviewed
Aug 19, 2025
tlively
approved these changes
Aug 19, 2025
Ms2ger
approved these changes
Aug 21, 2025
| 1. [=Throw=] a {{TypeError}} exception. | ||
| 1. Let |buffer| be **this**.\[[BufferObject]]. | ||
| 1. If [=IsFixedLengthArrayBuffer=](|buffer|) is false, return |buffer|. | ||
| 1. Assert |memtype| has a max. |
There was a problem hiding this comment.
Suggested change
| 1. Assert |memtype| has a max. | |
| 1. Assert: |memtype| has a max. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1895
PTAL @tlively or redirect