Added support for anyOf/oneOf/allOf for DTOs #1304
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcuri82
requested changes
Aug 28, 2025
| } | ||
| else -> { | ||
| throw IllegalStateException("Gene $primaryGene is not supported for DTO payloads") | ||
| val primaryGene = (it as BodyParam).primaryGene() |
There was a problem hiding this comment.
what happens if the body is optional, and the primary gene is a wrapper OptionalGene?
| is ObjectGene -> calculateDtoFromObject(gene, actionName) | ||
| is ArrayGene<*> -> calculateDtoFromArray(gene, actionName) | ||
| else -> { | ||
| throw IllegalStateException("Gene $gene is not supported for DTO payloads") |
There was a problem hiding this comment.
add some more info to help debugging if it happens, eg put the actionName somewhere in this error message
| if (template is ObjectGene) { | ||
| calculateDtoFromObject(template, actionName) | ||
| } else { | ||
| log.debug("Arrays of non custom objects are not collected as DTOs") |
There was a problem hiding this comment.
maybe use a unique warn? LoggingUtil.uniqueWarn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Specs with
anyOf,oneOfandallOfnow generate DTOs. For each of them, the resulting DTO is a merge of all the options in the spec