Skip to content

Upgrade to use react 19 #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Upgrade to use react 19 #194

wants to merge 6 commits into from

Conversation

dbaltor
Copy link

@dbaltor dbaltor commented Jun 24, 2025

I have upgraded the following libraries:

  • react 19.1.0
  • react-dom 19.1.0
  • react-leaflet 5.0.0
  • vite 7.0.0
  • babel 7.27.1
  • yarn 1.22.22

@SimonPaul02
Copy link

lgtm, lets merge, I need it for react 19

SimonPaul02
SimonPaul02 suggested changes Jun 28, 2025
View reviewed changes
Copy link

@SimonPaul02 SimonPaul02 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SimonPaul02
SimonPaul02 approved these changes Jun 28, 2025
View reviewed changes
Copy link

@SimonPaul02 SimonPaul02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm let's merge!

@dbaltor dbaltor closed this Jun 28, 2025
@dbaltor dbaltor reopened this Jun 28, 2025
@gil-obradors
Copy link

will close #190

@dbaltor
Copy link
Author

dbaltor commented Jun 29, 2025

Thank you @SimonPaul02 for reviewing and approving this.
Now we need somebody with push access to merge this. I can't do it.

@Sdann26
Copy link

Sdann26 commented Jul 2, 2025

I need this change uwu

@gil-obradors
Copy link

@Sdann26 in the meantime you can install the fork of @dbaltor
pnpm add "git+https://github.com/dbaltor/react-leaflet-draw.git"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@SimonPaul02 SimonPaul02 SimonPaul02 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbaltor @SimonPaul02 @gil-obradors @Sdann26